Yura Zenevich [:yzen] (please use "needinfo") Reporter
	Description • 10 years ago

Currently the seek bar is not operable and does not have proper semantics.
We need to ensure that it is implemented as a slider that will solve both: being operable and understandable.

	Ross
	Comment 1 • 10 years ago

Yura,

I'm running Boot2Gecko 2.2.0.0 on a Flame phone and the seek bar seems to have been fixed in this release.  It has been implemented as a slider and it's fully-functional.

	Yura Zenevich [:yzen] (please use "needinfo") Reporter
	Comment 2 • 10 years ago

(In reply to Ross from comment #1)
> Yura,
> 
> I'm running Boot2Gecko 2.2.0.0 on a Flame phone and the seek bar seems to
> have been fixed in this release.  It has been implemented as a slider and
> it's fully-functional.

Thanks, I ll take a look and close this if it looks good.

	Eitan Isaacson [:eeejay] Assignee
	Comment 4 • 9 years ago

(In reply to Ross from comment #1)
> Yura,
> 
> I'm running Boot2Gecko 2.2.0.0 on a Flame phone and the seek bar seems to
> have been fixed in this release.  It has been implemented as a slider and
> it's fully-functional.

Thanks Ross for checking. The slider is implemented as a <progress> element, which is a good step. But it is still missing some key features:
1. Most importantly, it is not operable. It is read-only.
2. The value of the progress bar is in seconds and is not a human readable time (eg. 2:30).
3. It would be nice if the entire slider region provided the current time and duration while allowing the user to adjust the seek bar.

Attached is a patch that does that. Sorry, I didn't see your comments here before I wrote this, or I would have let you take this :)

	Ross
	Comment 5 • 9 years ago

(In reply to Eitan Isaacson [:eeejay] from comment #4)
> (In reply to Ross from comment #1)
> > Yura,
> > 
> > I'm running Boot2Gecko 2.2.0.0 on a Flame phone and the seek bar seems to
> > have been fixed in this release.  It has been implemented as a slider and
> > it's fully-functional.
> 
> Thanks Ross for checking. The slider is implemented as a <progress> element,
> which is a good step. But it is still missing some key features:
> 1. Most importantly, it is not operable. It is read-only.
> 2. The value of the progress bar is in seconds and is not a human readable
> time (eg. 2:30).
> 3. It would be nice if the entire slider region provided the current time
> and duration while allowing the user to adjust the seek bar.
> 
> Attached is a patch that does that. Sorry, I didn't see your comments here
> before I wrote this, or I would have let you take this :)

No worries Eitan :).  In retrospect, I realize my comment was a bit too optimistic as I think I was interpreting the Bug Title/Description to mean that the seek bar wasn't there at all (like there was just a placeholder in effect or something).

	Dominic Kuo [:dkuo]
	Comment 6 • 9 years ago

Comment on attachment 8568821 [details] [review]
[gaia] eeejay:bug-1069623 > mozilla-b2g:master

Eitan, sorry for the late review and thanks for working on this, the patch looks good to me(please read the github comments), however it reminds me that we probably need to patch open.html as well, since we should also make the music open activity accessible for the screen reader? if so, then I have filed bug 1145559 and we can use it as a followup.

	Eitan Isaacson [:eeejay] Assignee
	Comment 8 • 9 years ago

Thanks for the catch on open.html. It is a very simple one-liner similar to index.html, so I am just adding them here in this patch.

	GitHub Autolander Bot
	Comment 9 • 9 years ago

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/6fb68c6dd77a85475d860173a195806cecd4b8e8