Closed
Bug 1068058
Opened 10 years ago
Closed 10 years ago
Update Selection.containsNode according to the spec
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
|
4.81 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Specifically, this makes the first argument non-nullable.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → ehsan.akhgari
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8490107 -
Flags: review?(bugs)
|
||
Updated•10 years ago
|
Keywords: dev-doc-needed
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8490107 [details] [diff] [review] Update Selection.containsNode according to the spec >+Selection::ContainsNode(nsINode& aNode, bool aAllowPartial, ErrorResult& aRv) > { > nsresult rv; >- if (mRanges.Length() == 0 || !aNode) >+ if (mRanges.Length() == 0) > return false; Since you're fixing coding style elsewhere, why not here too
Attachment #8490107 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae2e4ca015fd
https://hg.mozilla.org/mozilla-central/rev/ae2e4ca015fd
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
|
|
||
Comment 5•10 years ago
|
||
Doc updated: https://developer.mozilla.org/en-US/Firefox/Releases/35#Interfaces.2FAPIs.2FDOM and https://developer.mozilla.org/en-US/docs/Web/API/Selection.containsNode#Browser_compatibility
Keywords: dev-doc-needed → dev-doc-complete
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•