Jose Manuel Cantera Reporter
	Description • 10 years ago

      No description provided.

	Adrián de la Rosa Assignee
	Comment 1 • 10 years ago

Pull request with the requested integration test. I created a new suit because the first part of the two tests proposed is the same. One of them checks if we get the correct warning and the other checks if the contact has been deleted from ICE contacts.

	Adrián de la Rosa Assignee
	Comment 2 • 10 years ago

I updated the pull request with a version that fixes everything commented on GitHub except one thing explained there. Working fine in local, every time I tried it passed. I think it's also important to know that right now ice_test.js is blacklisted (bug 1071943).

	Cristian Rodriguez (:crdlc)
	Comment 3 • 10 years ago

Comment on attachment 8493703 [details] [review]
Pull Request #24338

LGTM. I left some minor comments in Github. Thanks a lot

	Adrián de la Rosa Assignee
	Comment 4 • 10 years ago

PR updated according to your comments, thanks a lot! You can merge when you please, since this file is blacklisted and TBPL won't even execute it :/

	Cristian Rodriguez (:crdlc)
	Comment 5 • 10 years ago

Why is this file blacklisted?

(In reply to Adrián de la Rosa from comment #4)
> PR updated according to your comments, thanks a lot! You can merge when you
> please, since this file is blacklisted and TBPL won't even execute it :/

	Cristian Rodriguez (:crdlc)
	Comment 6 • 10 years ago

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/e835b38c5e820099c26b4b08ac6a6db88adf78b0

	Adrián de la Rosa Assignee
	Comment 7 • 10 years ago

It was blacklisted because a test in that file was failing too much and the whole file was deactivated. You can see it here: https://github.com/mozilla-b2g/gaia/commit/b3bf31d8158ba9ba0a5dbb4f0c7afb1643b0de5f and the discussion about it here: https://bugzilla.mozilla.org/show_bug.cgi?id=1071943