Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Description • 10 years ago

'audio-channel-changed' event is fired every time when screen reader speaks. This triggers the redraw based on audio play icon and, if screen reader focus is inside the statusbar, the focus also jumps.

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 1 • 10 years ago

This also improves performance when the screen reader is on.

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 2 • 10 years ago

Comment on attachment 8484398 [details] [review]
Github pull request.

I think this summary should be corrected to
"Status bar needs to ignore continuous 'audio-channel-changed' event if the channel is the same."

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 3 • 10 years ago

https://github.com/mozilla-b2g/gaia/commit/3b76462c0377856d1b5cf454d12dde0ce8b768d4

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 4 • 10 years ago

This is a change to significantly improve system performance when the screen reader is on.

[Bug caused by] every time screen reader speaks, it is accompanied by the 'audio-channel-changed' event, even though the channel does not change. This triggers a complete status bar rewrite that affects the overall performance.
[User impact] If anyone enables the screen reader on the device, they will see a noticable performance hit when using it.
[Risk to taking this patch] The pull request is fairly simple + there are unit tests along with it.
[String changes made] None

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 5 • 10 years ago

Comment on attachment 8484398 [details] [review]
Github pull request.

This is a change to significantly improve system performance when the screen reader is on.

[Bug caused by] (feature/regressing bug #): every time screen reader speaks, it is accompanied by the 'audio-channel-changed' event, even though the channel does not change. This triggers a complete status bar rewrite that affects the overall performance.

[User impact] if declined: If anyone enables the screen reader on the device, they will see a noticable performance hit when using it.

[Testing completed]: New unit tests pass on try.

[Risk to taking this patch] (and alternatives if risky): The pull request is fairly simple + there are unit tests along with it.

[String changes made]: None

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 10 years ago

v2.1: https://github.com/mozilla-b2g/gaia/commit/de74bb0fdaedcbce3b596226786aaabe5a1355d4