Greg Reporter
	Description • 10 years ago

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140825202822

Steps to reproduce:

1. Set font color and window background color for in Win 7 Control Panel/Personalization for the High Contrast White Desktop Theme (e.g. black font and grey window background), and apply this Desktop Theme.

2. Visit any website (e.g. Google) in Firefox 32.


Actual results:

Firefox 32 uses the colors that are set in the Win 7 High Contrast White Desktop Theme, even though Firefox Tools/Options/Content/Colors.../"Allow pages to choose their own colors, instead of my selections above" is checked. 


Expected results:

All web pages should have their own colors, NOT the Win 7 High Contrast White Desktop Theme colors.

Apparently, the Tools/Options/Content/Colors.../"Allow pages to choose their own colors, instead of my selections above" option is broken in Firefox 32.

	:Gijs (he/him)
	Comment 1 • 10 years ago

On Windows, we assume that if you use a high contrast theme, you actually need high contrast settings, so yes, this will affect how webpages are displayed. This is by design, last I checked, and expected by most people who use high contrast themes. We broke this in Firefox 31, and it was fixed for 32... right David? (bug 1042625 - AFAICT this code has overridden the checkbox comment #0 refers to since bug 239914 was implemented on Windows 10 years ago)

	David Bolter [:davidb] (NeedInfo me for attention)
	Comment 2 • 10 years ago

Right. I don't recall "Allow pages to choose their own colors, instead of my selections above" ever overriding windows hcm and I think that is by design (I could be wrong).

Greg is your use case that you want Windows HCM for everything on your windows desktop except web content?

	Greg Reporter
	Comment 3 • 10 years ago

(In reply to :Gijs Kruitbosch from comment #1)
> On Windows, we assume that if you use a high contrast theme, you actually
> need high contrast settings, so yes, this will affect how webpages are
> displayed. This is by design, last I checked, and expected by most people
> who use high contrast themes. We broke this in Firefox 31, and it was fixed
> for 32... right David? (bug 1042625 - AFAICT this code has overridden the
> checkbox comment #0 refers to since bug 239914 was implemented on Windows 10
> years ago)

Gijs, this was not "broken" in Firefox 31.  On the contrary, it worked fine.  If the user wanted to have the high contrast settings to come through on web pages, he/she could have overridden "Allow pages to choose their own colors, instead of my selections above," by unchecking that check box.  That was the whole purpose of that dialog.  The changes made in Firefox 32 completely nullified the functionality of that entire dialog.  There is absolutely no reason for Windows colors of the High Contrast Desktop Themes to be treated any differently than the Windows colors of any of the other Desktop Themes. The changes made in Firefox 32 have destroyed this consistency of controlling where the colors are coming from (i.e. from the webpage or from Windows).

	Greg Reporter
	Comment 4 • 10 years ago

(In reply to David Bolter [:davidb] from comment #2)
> Right. I don't recall "Allow pages to choose their own colors, instead of my
> selections above" ever overriding windows hcm and I think that is by design
> (I could be wrong).
> 
> Greg is your use case that you want Windows HCM for everything on your
> windows desktop except web content?

David, your assumption that "Allow pages to choose their own colors, instead of my selections above" does not override Windows HCM, is NOT correct.  If that check box is checked, it will override Windows HCM.  If that check box is unchecked, then Windows HCM will come through.  I downgraded from Firefox 32 back to Firefox 31, and this dialog works perfectly fine.

In answer to your question, yes, I do want Windows HCM for everything on my Windows desktop, except web content, and I don't want to have to switch back and forth between Windows Desktop Themes to accomplish this.  Some webpages are actually unreadable in Firefox32, which requires that Windows HCM comes through, because some objects on the webpage may be the same color as the Windows background color that has been set in the Win7 High Contrast White Theme, and they will not show up.  On the other hand, there are some instances where I would want Windows HCM to come through on webpages, especially on webpages that have a lot of documentation that I have to read on a harsh white background, which gives me a headache.  In these instances, I would want to uncheck the "Allow pages to choose their own colors..." check box to allow the Windows HCM to come through.

The reason why I use the High Contrast White Theme is because, with the advent of Windows 7 and those silly Aero Desktop Themes (I upgraded from Windows XP), Microsoft virtually stripped away most of the user control of Windows colors.  I have found that the High Contrast White Theme allows the greatest control of color for most of the Windows objects, and that is why I use it.

The assumption that "...if you use a high contrast theme, you actually need high contrast settings..." is not always true, as I have just explained above.  Also, as I explained to Gijs above, there is absolutely no reason for Windows colors of the High Contrast Desktop Themes to be treated any differently than the Windows colors of any of the other Desktop Themes.  Why would you want to do this, when you have full control through the Firefox dialog option, which preserves the consistency of controlling where the colors are coming from (i.e. from the webpage or from Windows)?

I'm begging you to please change this back to the way it worked in Firefox 31.  This dialog gives complete flexibility to the user to determine where the colors are coming from.  Firefox 32 nullifies this control and takes this flexibility away from the user.

I will NOT upgrade from Firefox 31 to any future versions of Firefox until this bug has been fixed.

	Greg Reporter
	Comment 5 • 10 years ago

Attached is an example of a webpage, which the user is FORCED to look at with Firefox 32, if he/she is using a High Contrast Desktop Theme (Page 2 of the PDF document).  This is the perfect example, which illustrates that "...if you use a high contrast theme, you actually need high contrast settings..." is not always true. In this case the user would most likely want to check the "Allow pages to choose their own colors..." check box, but this is not possible in Firefox 32, because the functionality of this dialog has been stripped away.

	David Bolter [:davidb] (NeedInfo me for attention)
	Comment 6 • 10 years ago

I just ran Windows (Windows 7 Pro 32bit VM) HCM in various Firefox versions with the following results:

Firefox 25: web content respects HCM, chrome pages respect HCM
Firefox 26: I didn't test.
Firefox 27: web content respects HCM, chrome pages respect HCM
Firefox 28: web content respects HCM, chrome pages respect HCM
Firefox 29: web content ignores  HCM, chrome pages respect HCM
Firefox 30: web content ignores  HCM, chrome pages respect HDM
Firefox 31: web content ignores  HCM, chrome pages respect HDM
Firefox 32: web content respects HCM, chrome pages respect HCM

Looks like we had 3 versions with Greg's preferred behaviour. I was unable to confirm the checkbox having any effect on HCM web content override (I tried most versions above).

In any evernt, given that the web is pretty broken in Windows HCM mode I agree we should allow the user to block Windows HCM for web content.

	:Gijs (he/him)
	Comment 7 • 10 years ago

(In reply to David Bolter [:davidb] from comment #6)
> I just ran Windows (Windows 7 Pro 32bit VM) HCM in various Firefox versions
> with the following results:
> 
> Firefox 25: web content respects HCM, chrome pages respect HCM
> Firefox 26: I didn't test.
> Firefox 27: web content respects HCM, chrome pages respect HCM
> Firefox 28: web content respects HCM, chrome pages respect HCM
> Firefox 29: web content ignores  HCM, chrome pages respect HCM
> Firefox 30: web content ignores  HCM, chrome pages respect HDM
> Firefox 31: web content ignores  HCM, chrome pages respect HDM
> Firefox 32: web content respects HCM, chrome pages respect HCM
> 
> Looks like we had 3 versions with Greg's preferred behaviour. I was unable
> to confirm the checkbox having any effect on HCM web content override (I
> tried most versions above).
> 
> In any evernt, given that the web is pretty broken in Windows HCM mode I
> agree we should allow the user to block Windows HCM for web content.

I think we should migrate the use_document_colors pref into a tristate pref, in that case, with 0 == "don't use colors", 1 "use colors", and 2 (default): "use theme default" (which equals "use document colors == true" for everyone except hcm).

	Alice0775 White
	Comment 8 • 10 years ago

Dup Bug 639134 ?