Loli (:lolimartinezcr) Reporter
	Description • 10 years ago

Flame
2.1
Gecko-6be7031
Gaia-e1f6d88

Pre-requisites:
1. Contacts saved.

STRs:
1.Tap contact application.
2. Tap settings.
3. Tap "Set ICE contacts".
4. Tap "Select ICE contact".
5. Tap search button.
6. Write some substring (substring of some contact)
7. Tap in result of search.

Actual result:
Contact is edited (but user doesn't know if this contact is selected), when presses "back" go back to result of search (but user doesn't know if this contact is selected) and after presses "Cancel" button.

I think this process is confuse for user and user has to do some steps not clearly for select a contact

Expected result:
Need info UX.

Expected result

	Maria Angeles Oteo (:oteo)
	Comment 1 • 10 years ago

I agree with Loli, it's really confusing for the user, to be able to select a contact from the search result, I have to:
1. step 7, tap on the searched contact and enter in contact details
2. Press "<" button on the left to go back to the search screen
3. press cancel button to go back to the ICE Contact screen in settings
and only in that screen you realize that you have selected the searched contact

IMHO, after step 7 (tapping on the contact selected from the search) I would expect coming back to the ICE contacts screen in contact setting with the name of the selected contact already included in the IC1 or IC2 field.

Carrie, can you give us your feedback about this issue?
Francisco, do you think it's a feasible solution?

Thanks a lot!

	Maria Angeles Oteo (:oteo)
	Comment 2 • 10 years ago

[Blocking Requested - why for this release]: Annoying User experience, really confusing search flow from the ICE Contacts screen

	Wesley Huang [:wesley_huang] (EPM) (NI me)
	Comment 3 • 10 years ago

triage: bad user experience on the new feature

	Francisco Jordano [:arcturus] [:francisco]
	Comment 4 • 10 years ago

Well, those step were not intentionally set there. Are the result of a bug, IMHO, once we select from the search list we should select it.

Carrie what do you think?

	Carrie Wang [New account: carrie75521@gmail.com]
	Comment 5 • 10 years ago

Yes the behavior is really weird.

After inputting the substring of a contact and we display the matched results on the list, user can then taps a result which means it's selected and then we go back to the ICE settings page and show the selected contact name in the field. This is the correct flow of the search function.
Thanks!

	Adrián de la Rosa Assignee
	Comment 6 • 10 years ago

I'll take a look at it.

	Adrián de la Rosa Assignee
	Comment 7 • 10 years ago

Fixed, but tests are missing. To test this, I suppose an integration test will be better, and since I'm having problems executing them I propose we open a follow up bug to make a test for this bug, so we can have the bug landed before friday.

	Jose Manuel Cantera
	Comment 8 • 10 years ago

Comment on attachment 8490707 [details]
Pull Request #23905

thanks Adrian

	Jose Manuel Cantera
	Comment 9 • 10 years ago

landed in master:

https://github.com/mozilla-b2g/gaia/commit/85730dc68cf41e79126f8125cb48aab7153dbace

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 10 years ago

Please request Gaia v2.1 approval on this when you get a chance.

	Jose Manuel Cantera
	Comment 11 • 10 years ago

Comment on attachment 8490707 [details]
Pull Request #23905

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): New Feature ICE Contacts
[User impact] if declined: High. User can lose context while interacting with the app
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low-risk patch
[String changes made]:

	Loli (:lolimartinezcr) Reporter
	Comment 12 • 10 years ago

Tested and working
Flame
User
2.2
Gecko: 45f4500
Gaia: d170091

Pending 2.1

	[:fabrice] Fabrice Desré
	Comment 13 • 10 years ago

Comment on attachment 8490707 [details]
Pull Request #23905

Ask for approval once the test from https://bugzilla.mozilla.org/show_bug.cgi?id=1062168#c7 is done.

	Jose Manuel Cantera
	Comment 14 • 10 years ago

Comment on attachment 8490707 [details]
Pull Request #23905

Fabrice, now we have tests for this feature. See Bug 1069242 comment #6 

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): New Feature ICE Contacts
[User impact] if declined: High. User can lose context while interacting with the app
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low-risk patch
[String changes made]:

	Ryan VanderMeulen [:RyanVM]
	Comment 15 • 10 years ago

v2.1: https://github.com/mozilla-b2g/gaia/commit/2913cacd45dbc488ea21158aba26354286238bd7

	Loli (:lolimartinezcr) Reporter
	Comment 16 • 10 years ago

Tested and working
2.1
Flame
User
Gecko-5cf7098
Gaia-700f481

	Duane Dixon [:ddixon]
	Comment 17 • 10 years ago

Issue is verified fixed in Flame 2.2, 2.1 builds (Full Flash, nightly). 

Actual Results: Searching and selecting ICE contacts behaves correctly. 

Device: Flame Master
Build ID: 20141023040204
Gaia: 27a1d1baaa8e375b70e043efee67d5f2206c330b
Gecko: 88adcf8fef83
Version: 36.0a1 (Master)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Device: Flame 2.1
Build ID: 20141023001201
Gaia: 1e48e3e40e0780c0cd07a3457e5fe2efeeb542d1
Gecko: 09fb60a37850
Version: 34.0 (2.1)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0