Marcus Cavanaugh [:mcav] Reporter
	Description • 10 years ago

Per the email.js transition in bug 885110, BrowserBox and SmtpClient did not support STARTTLS, so we monkeypatched it in js/imap/client.js and js/smtp/client.js. When these libraries release new versions with support for that, we should remove our monkeypatches.

	Marcus Cavanaugh [:mcav] Reporter
	Comment 1 • 10 years ago

The corresponding issues on GitHub:

https://github.com/whiteout-io/browserbox/issues/20
https://github.com/whiteout-io/smtpclient/ues/8

	Andrew Sutherland [:asuth] (he/him)
	Comment 2 • 10 years ago

Note that both originals issues have been closed, but the patches landed thus far are for opportunistic STARTTLS support and do not mandate it, so they aren't entirely suitable yet.  At least per our bug-filing idiom, I've created new issues rather than reopening.  They are:

https://github.com/whiteout-io/browserbox/issues/28
https://github.com/whiteout-io/smtpclient/issues/13

	Benjamin Podszun
	Comment 3 • 10 years ago

Looking at the upstream bugs, issue 28 seems fixed (closed upstream, relevant test seems to be here [1]) and so does issue 13 (closed upstream, pull request [2]).

Is there anything else that is blocking this bug/that this bug is tracking?

1: https://github.com/whiteout-io/browserbox/blob/76baf18ce919322d1d7bb5a7c23a91074ca5908c/test/integration/browserbox-test.js#L161

2: https://github.com/whiteout-io/smtpclient/pull/14

Is this bug

	Andrew Sutherland [:asuth] (he/him)
	Comment 4 • 10 years ago

Fixed as part of bug 1097421's omnibus patch. Many servers were experiencing more than one bug, and we had experienced some upstream drift, and especially for uplift tracking, it made sense to land these together.  See the gaia-email-libs-and-more pull request's specific commits for the specific fixes and tests.  I am planning to request v2.1 uplift shortly after performing v2.1 testing.

	Andrew Sutherland [:asuth] (he/him)
	Comment 5 • 9 years ago

Batching marking v2.1 fixed since the uplift of bug 1097421 occurred on Dec 9th, thereby fixing all dependent bugs of bug 1097421 on v2.1.  Uplift commit comment is https://bugzilla.mozilla.org/show_bug.cgi?id=1097421#c6