Chris Pearce [:cpearce (Not reading bugmail)] Assignee
	Description • 10 years ago

https://dvcs.w3.org/hg/html-media/raw-file/default/encrypted-media/encrypted-media.html#dom-getusablekeyids

	Chris Pearce [:cpearce (Not reading bugmail)] Assignee
	Comment 1 • 10 years ago

Implement MediaKeySession.getUsableKeyIds().

	Boris Zbarsky [:bzbarsky]
	Comment 2 • 10 years ago

Comment on attachment 8478083 [details] [diff] [review]
Patch

>+  if (!ToJSValue(cx, keyIds, &array)) {

You shouldn't need this.  This should work fine for the behavior your code has right now:

  promise->MaybeResolve(keyIds);

(which will under the hood do the ToJSValue, reject if that fails, etc).  Note that you also won't need cx in that case.

>+  Promise<sequence<ArrayBuffer>> getUsableKeyIds();

That said, if you want the behavior this IDL describes, you need something different.  keyIds is an nsTArray<nsTArray<uint8_t>>.  Calling ToJSValue on it will produce an array of arrays of numbers, not an array of arraybuffers.  So if you want the latter you need to do the conversion more carefully: first construct an nsTArray<TypedArrayCreator<ArrayBuffer>> whose elements are pointing to the elements of keyIds, then resolve the promise with _that_.

And clearly this needs a test to make sure the right sort of thing is returned.

	Chris Pearce [:cpearce (Not reading bugmail)] Assignee
	Comment 3 • 10 years ago

I updated the patch to use nsTArray<TypedArrayCreator<ArrayBuffer>>.

I have tested this with my example EME GMP, so I know this is working.

But yes, we absolutely do need an automated test here. Edwin is working on our ClearKey CDM implementation which we will use for most EME testing in bug 1044742. ClearKey is specified to support this API, so we'll be testing it with that GMP.

	Boris Zbarsky [:bzbarsky]
	Comment 4 • 10 years ago

Comment on attachment 8479454 [details] [diff] [review]
Patch v2

r=me.  Looks great!

	Chris Pearce [:cpearce (Not reading bugmail)] Assignee
	Comment 5 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/f73be78d1cca

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 6 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/f73be78d1cca

	Chris Pearce [:cpearce (Not reading bugmail)] Assignee
	Comment 7 • 9 years ago

Mass update firefox-status to track EME uplift.