Anne (:annevk) Reporter
	Description • 10 years ago

It's not really worth renaming this I think. Let's embrace the web.

	Andrea Marchesini [:baku] Assignee
	Comment 1 • 10 years ago

https://tbpl.mozilla.org/?tree=Try&rev=b227b2eba9df

	Anne (:annevk) Reporter
	Comment 2 • 10 years ago

Comment on attachment 8475203 [details] [diff] [review]
named.patch

The new name should be NamedNodeMap, not NamedAttrMap.

	Andrea Marchesini [:baku] Assignee
	Comment 3 • 10 years ago

https://tbpl.mozilla.org/?tree=Try&rev=e2c0780e8214

This patch keeps nsIDOMMozNamedAttrMap but without any methods and attributes just to be compatible with existing addons. I marked this interface builtinclass.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 4 • 10 years ago

Name NamedNodeMap of course doesn't make any sense, but since DOM 3 Core had that (for Nodes, not only for Attrs), I guess this is fine.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 5 • 10 years ago

Comment on attachment 8475275 [details] [diff] [review]
named.patch

Since we have even internal usage for the .idl interface, I wouldn't remove it.
The casting is ugly and error prone.

Why not just rename the webidl interface?

	Andrea Marchesini [:baku] Assignee
	Comment 6 • 10 years ago

https://tbpl.mozilla.org/?tree=Try&rev=ab4d8237fbd3

Ok, I just tried to remove a idl interface with this patch. But it can be done in a different patch.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 7 • 10 years ago

Comment on attachment 8476607 [details] [diff] [review]
named.patch

>-/**
>- * This is a temporary, non-standard interface, to ease the transition to a
>- * world where Attr no longer inherits from Node.
>- */
>-
I don't see reason for this change.

	Andrea Marchesini [:baku] Assignee
	Comment 8 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e528ecd25c9

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/4e528ecd25c9

	Jean-Yves Perrier [:teoli]
	Comment 10 • 10 years ago

Updated doc:
https://developer.mozilla.org/en-US/Firefox/Releases/34
https://developer.mozilla.org/en-US/docs/Web/API/NamedNodeMap
https://developer.mozilla.org/en-US/docs/Web/API/Element.attributes