Anne (:annevk) Reporter
	Description • 10 years ago

For links that open in a new window, e.g. from Gmail, redirects are followed automatically after flipping browser.tabs.remote.autostart.

	Dão Gottwald [:dao]
	Comment 1 • 10 years ago

This is supposed to be handled by TabsProgressListener.onRefreshAttempted:

http://hg.mozilla.org/mozilla-central/annotate/111a1da2a95d/browser/base/content/browser.js#l4218

	Jim Mathies [:jimm]
	Comment 2 • 10 years ago

not blocking m2, sorry.

	Tracy Walker [:tracy]
	Comment 3 • 8 years ago

I can reproduce this on latest Nightly with test case from bug 1150311: https://bugzilla.mozilla.org/attachment.cgi?id=8590090

I'll provide a full report shortly, but I want to get his into today's triage as I feel this is higher priority than trackinge10s+.

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 4 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/33819/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33819/

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 5 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/33821/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33821/

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 6 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/33823/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33823/

	Dave Townsend [:mossop]
	Comment 7 • 8 years ago

Comment on attachment 8716463 [details]
MozReview Request: Bug 1055464 - Add RefreshBlocker to tab-content, and a listener in tabbrowser.xml. r=Mossop

https://reviewboard.mozilla.org/r/33819/#review30641

::: browser/base/content/tab-content.js:758
(Diff revision 1)
> +  },

When you don't include a method xpconnect automatically just throws NS_ERROR_NOT_IMPLEMENTED when called anyway so I don't think these are useful.

	Dave Townsend [:mossop]
	Comment 8 • 8 years ago

Comment on attachment 8716464 [details]
MozReview Request: Bug 1055464 - Add RefreshBlocker front-end. r=Mossop

https://reviewboard.mozilla.org/r/33821/#review30645

::: browser/base/content/global-scripts.inc:27
(Diff revision 1)
> +<script type="application/javascript" src="chrome://browser/content/browser-refreshblocker.js"/>

Please also update https://dxr.mozilla.org/mozilla-central/source/testing/eslint-plugin-mozilla/lib/rules/import-browserjs-globals.js

	Dave Townsend [:mossop]
	Comment 9 • 8 years ago

Comment on attachment 8716465 [details]
MozReview Request: Bug 1055464 - Regression tests. r=Mossop

https://reviewboard.mozilla.org/r/33823/#review30651

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 10 • 8 years ago

Comment on attachment 8716463 [details]
MozReview Request: Bug 1055464 - Add RefreshBlocker to tab-content, and a listener in tabbrowser.xml. r=Mossop

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33819/diff/1-2/

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 11 • 8 years ago

Comment on attachment 8716464 [details]
MozReview Request: Bug 1055464 - Add RefreshBlocker front-end. r=Mossop

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33821/diff/1-2/

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 12 • 8 years ago

Comment on attachment 8716465 [details]
MozReview Request: Bug 1055464 - Regression tests. r=Mossop

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33823/diff/1-2/

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 13 • 8 years ago

https://hg.mozilla.org/integration/fx-team/rev/667d574c768d48f287324f30792309f93ed37668
Bug 1055464 - Add RefreshBlocker to tab-content, and a listener in tabbrowser.xml. r=Mossop

https://hg.mozilla.org/integration/fx-team/rev/954e2015504392e23118e1ad71506b7e6d7aed78
Bug 1055464 - Add RefreshBlocker front-end. r=Mossop

https://hg.mozilla.org/integration/fx-team/rev/cb036027df84e7e547bf3f9614b71857e5059741
Bug 1055464 - Regression tests. r=Mossop

	Carsten Book [:Tomcat]
	Comment 14 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/667d574c768d
https://hg.mozilla.org/mozilla-central/rev/954e20155043
https://hg.mozilla.org/mozilla-central/rev/cb036027df84

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 15 • 8 years ago

Comment on attachment 8716463 [details]
MozReview Request: Bug 1055464 - Add RefreshBlocker to tab-content, and a listener in tabbrowser.xml. r=Mossop

Approval Request Comment
[Feature/regressing bug #]:

Electrolysis, and the accessibility / user control setting for protecting the user from automatic redirection / reload.

[User impact if declined]:

Users that have e10s enabled will not be able to prevent sites from redirecting or reloading despite having the preference set.

Note that this isn't just an about:config pref, but a preference that we expose in about:preferences under Advanced > General.

[Describe test coverage new/current, TreeHerder]:

I've added automated tests for this.

[Risks and why]: 

This bug has opened up a 5% session restore talos regression on Linux 64, being tracked in bug 1247100. There are no regressions being tracked on any of the other platforms.

[String/UUID change made/needed]:

None.

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 16 • 8 years ago

Comment on attachment 8716464 [details]
MozReview Request: Bug 1055464 - Add RefreshBlocker front-end. r=Mossop

Approval Request Comment

See comment 15.

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 17 • 8 years ago

Comment on attachment 8716465 [details]
MozReview Request: Bug 1055464 - Regression tests. r=Mossop

Approval Request Comment

See comment 15.

	Tracy Walker [:tracy]
	Comment 18 • 8 years ago

This doesn't appear to be fixed.  Might even be worse depending on your perspective.  See bug 1246291.  There I reported that the redirect warming is not appearing, nor is the page redirecting.

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 19 • 8 years ago

[Tracking Requested - why for this release]:

Tracy, do you mean this isn't fixed in nightly?   If so, can you reopen the bug/set the flags accordingly?
Mike, I will hold off on uplift for now and wait on developments in bug 1246291 if that seems right to you.

	Tracy Walker [:tracy]
	Comment 20 • 8 years ago

Thanks Liz, I thought I had re-opened this when I made the connection in bug 1246291.  Note: they are probably dupes. Unless the work for displaying the warning and the work for actually not redirecting will be treated separately, in which case, this bug should be used for the former and bug 1246291 used for the latter.

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 21 • 8 years ago

I would argue that this bug should be closed, and that the remaining work should occur in bug 1246291.

The reason for that is because the patch in this bug, as landed, DOES fix the STR that are laid out in comment 0 and comment 3.

The issue in bug 1246291 is a special-case of redirecting (redirect via the HTTP header, instead of a <meta> tag in an HTML document body).

The patch in this bug fixes the latter case for e10s. It also unintentionally fixes the former case (HTTP header redirect) for non-e10s. It does not fix the former case for the e10s case. That's what bug 1246291 is for.

Tracy, does that gel with your observations? If so, we can re-close this and continue the work in bug 1246291?

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 22 • 8 years ago

Sounds good to me.

	Tracy Walker [:tracy]
	Comment 23 • 8 years ago

Yes, sounds good.

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 24 • 8 years ago

Untracking since this is tracked in 1246291.

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 25 • 8 years ago

Comment on attachment 8716463 [details]
MozReview Request: Bug 1055464 - Add RefreshBlocker to tab-content, and a listener in tabbrowser.xml. r=Mossop

Fixes redirects with e10s along with patches in bug 1246291.
Wes - may be best to uplift these after 1246291.

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 26 • 8 years ago

Thanks!

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/7a921d6901b2
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/ac3712cca8f1
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/d7bb8f1900c5

	Mayur Patil
	Comment 27 • 8 years ago

[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Component: 
Name 			Firefox
Version 		46.0b4
Build ID 		20160322075646
Update Channel 	        beta
User Agent 		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS                      Windows 7 SP1 x86_64

Actual Results: 
As expected

Expected Results: 
No automatic redirections are there for sites like Gmail.
Not reproducible for FF 46.0b4.