Closed Bug 1043522 Opened 10 years ago Closed 10 years ago

Subsequent searches will quickly flash the previous search in the WebView

Categories

(Firefox for Android Graveyard :: Search Activity, defect)

Product:
Firefox for Android Graveyard
Component:
Search Activity
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox34 affected)

Status:
RESOLVED FIXED
Milestone:
Firefox 34
Tracking Flags:
Tracking Status
firefox34 --- affected

People

(Reporter: mfinkle, Assigned: eedens)

References

Details

Attachments

(1 file)

bug-1043522-fix.patch
1.26 KB, patch
Margaret
: review+
Details | Diff | Splinter Review 
Happens if I search for something, then come back and search again. The WebView is still displaying the previous search and I see it flash on screen.

We should clear the old search when starting a new one.
Clear the webview before loading a new page.

PR: https://github.com/ericedens/FirefoxSearch/pull/48
Assignee: nobody → eric.edens
Status: NEW → ASSIGNED
Attachment #8466451 - Flags: review?(margaret.leibovic)
Comment on attachment 8466451 [details] [diff] [review]
bug-1043522-fix.patch

Review of attachment 8466451 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds reasonable to me.
Attachment #8466451 - Flags: review?(margaret.leibovic) → review+
Hey Margaret! Could you land this in FX team when you get a chance?
Flags: needinfo?(margaret.leibovic)
https://hg.mozilla.org/mozilla-central/rev/02efb609a3f7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Flags: needinfo?(margaret.leibovic)
Depends on: 1049650
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: