Brandon Frohs Reporter
	Description • 10 years ago

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140608211622

Steps to reproduce:

Added `text-align-last:justify` to an element.


Actual results:

`text-align-last` was discarded. `-moz-text-align-last` works.


Expected results:

`text-align-last` should be accepted like `-moz-text-align-last`.

Spec: http://www.w3.org/TR/css-text-3/#text-align-last-property

Last change to `text-align-last` was in the latest version (10 October 2013).

One issue regarding `text-align-last`: http://www.w3.org/Style/CSS/Tracker/issues/333

Side note: Gmail discards `-moz-text-align-last` in emails, but keeps `text-align-last`.

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 1 • 8 years ago

So it seems we pass all tests in CSSWG on text-align-last if we unprefix it.

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 2 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/55742/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55742/

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 3 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/55744/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55744/

	David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)
	Comment 4 • 8 years ago

Could you (1) send an intent to ship and (2) file a bug to remove the alias?

(I think shipping unprefixed seems reasonable if that's what blink and edge have done (which your whiteboard annotation makes me suspect) or if it's in a CR draft (which I'm not sure of).)

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 5 • 8 years ago

caniuse.com says Edge and even IE does, but it seems it is wrong. According to my test, Blink indeed has shipped unprefixed text-align-last, but Edge doesn't.

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 6 • 8 years ago

Comment on attachment 8757164 [details]
MozReview Request: Bug 1039541 part 1 - Unprefix text-align-last. r?heycam

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55742/diff/1-2/

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 7 • 8 years ago

Comment on attachment 8757165 [details]
MozReview Request: Bug 1039541 part 2 - Use unprefixed text-align-last in tests. r?heycam

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55744/diff/1-2/

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 8 • 8 years ago

Intent to ship: https://groups.google.com/d/msg/mozilla.dev.platform/jbMO8mkFZwE/ATXLMHECPAAJ

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 9 • 8 years ago

Comment on attachment 8757164 [details]
MozReview Request: Bug 1039541 part 1 - Unprefix text-align-last. r?heycam

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55742/diff/2-3/

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 10 • 8 years ago

Comment on attachment 8757165 [details]
MozReview Request: Bug 1039541 part 2 - Use unprefixed text-align-last in tests. r?heycam

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55744/diff/2-3/

	David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)
	Comment 11 • 8 years ago

(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #5)
> caniuse.com says Edge and even IE does, but it seems it is wrong. According
> to my test, Blink indeed has shipped unprefixed text-align-last, but Edge
> doesn't.

Maybe file an issue at https://github.com/Fyrd/caniuse/issues ?

	Cameron McCormack (:heycam)
	Comment 12 • 8 years ago

Comment on attachment 8757164 [details]
MozReview Request: Bug 1039541 part 1 - Unprefix text-align-last. r?heycam

https://reviewboard.mozilla.org/r/55742/#review52778

	Cameron McCormack (:heycam)
	Comment 13 • 8 years ago

Comment on attachment 8757165 [details]
MozReview Request: Bug 1039541 part 2 - Use unprefixed text-align-last in tests. r?heycam

https://reviewboard.mozilla.org/r/55744/#review52780

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 14 • 8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/16f29c411ce6a378f4456cd97c9221d5e797f063
Bug 1039541 part 1 - Unprefix text-align-last. r=heycam

https://hg.mozilla.org/integration/mozilla-inbound/rev/cec360c7fbc9a75c86fa88f342743e59a8468915
Bug 1039541 part 2 - Use unprefixed text-align-last in tests. r=heycam

	Carsten Book [:Tomcat]
	Comment 15 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/16f29c411ce6
https://hg.mozilla.org/mozilla-central/rev/cec360c7fbc9

	Kohei Yoshino [:kohei]
	Comment 16 • 8 years ago

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/text-align-last-has-been-unprefixed/

	yisibl
	Comment 17 • 8 years ago

Update:

https://developer.mozilla.org/en-US/docs/Web/CSS/text-align-last#Browser_compatibility
https://developer.mozilla.org/en-US/Firefox/Releases/49#CSS

	Jean-Yves Perrier [:teoli]
	Comment 18 • 8 years ago

Thanks percyley!