Jonathan Griffin (:jgriffin) Reporter
	Description • 10 years ago

If the semi-auto tests launch a browser in order to display the local status page, it will wait forever at the end of the tests for the browser to be closed, before continuing to the cert tests.

If the browser was already opened when the semi-auto tests are run, this isn't observed, probably because (at least for Firefox) the instance of the browser that's launched quickly terminates after passing the url it's launched with to the previously running instance.

The workaround is to make sure your browser is running before running the tests.

	Andreas Tolfsen ❲:ato❳
	Comment 2 • 10 years ago

I'm unable to reproduce this.  With no browser running, this is the output I get:

% python -m semiauto smoketests
 0:06.16 LOG: MainThread DEBUG Waiting for client
 0:07.76 LOG: Thread-1 DEBUG Accepted new client: 5204ed94-b585-452f-b727-a85ebf64e36a
WARNING:tornado.access:404 GET /favicon.ico (127.0.0.1) 0.81ms
 0:07.79 LOG: MainThread DEBUG Got client
 0:07.79 SUITE_START: MainThread 11
 0:07.79 TEST_START: MainThread smoketests.Smoketests.test_confirm
 0:15.52 LOG: Thread-1 DEBUG Received {"confirm_prompt_ok":null}
 0:15.77 TEST_END: MainThread Harness status PASS. Subtests passed 0/0. Unexpected 0
 0:15.77 TEST_START: MainThread smoketests.Smoketests.test_confirm_no
 0:20.45 LOG: Thread-1 DEBUG Received {"confirm_prompt_cancel":null}
 0:20.71 TEST_END: MainThread Harness status PASS. Subtests passed 0/0. Unexpected 0
 0:20.71 TEST_START: MainThread smoketests.Smoketests.test_expected_failure
 0:26.09 LOG: Thread-1 DEBUG Received {"instruct_prompt_cancel":null}
 0:26.10 TEST_END: MainThread Harness status FAIL. Subtests passed 0/0. Unexpected 0
 0:26.33 TEST_START: MainThread smoketests.Smoketests.test_instruct
 0:31.43 LOG: Thread-1 DEBUG Received {"instruct_prompt_ok":null}
 0:31.68 TEST_END: MainThread Harness status PASS. Subtests passed 0/0. Unexpected 0
 0:31.69 TEST_START: MainThread smoketests.Smoketests.test_instruct_cancel
 0:36.43 LOG: Thread-1 DEBUG Received {"instruct_prompt_cancel":null}
 0:36.71 TEST_END: MainThread Harness status PASS. Subtests passed 0/0. Unexpected 0
 0:36.71 TEST_START: MainThread smoketests.Smoketests.test_long_response
 0:45.00 LOG: Thread-1 DEBUG Received {"prompt":"oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo"}
 0:45.27 TEST_END: MainThread Harness status PASS. Subtests passed 0/0. Unexpected 0
 0:45.27 TEST_START: MainThread smoketests.Smoketests.test_prompt
 0:50.42 LOG: Thread-1 DEBUG Received {"prompt":"foo"}
 0:50.67 TEST_END: MainThread Harness status PASS. Subtests passed 0/0. Unexpected 0
 0:50.67 TEST_START: MainThread smoketests.Smoketests.test_prompt_empty
 0:55.11 LOG: Thread-1 DEBUG Received {"prompt":null}
 0:55.40 TEST_END: MainThread Harness status PASS. Subtests passed 0/0. Unexpected 0
 0:55.40 TEST_START: MainThread smoketests.Smoketests.test_prompt_number
 1:00.70 LOG: Thread-1 DEBUG Received {"prompt":"42"}
 1:00.94 TEST_END: MainThread Harness status PASS. Subtests passed 0/0. Unexpected 0
 1:00.95 TEST_START: MainThread smoketests.Smoketests.test_skip
 1:00.95 TEST_END: MainThread Harness status SKIP. Subtests passed 0/0. Unexpected 0
 1:00.95 TEST_START: MainThread smoketests.Smoketests.test_unexpected_success
 1:04.88 LOG: Thread-1 DEBUG Received {"instruct_prompt_ok":null}
 1:04.92 TEST_END: MainThread Harness status PASS, expected FAIL. Subtests passed 0/0. Unexpected 1
 1:05.16 SUITE_END: MainThread 

The program exits cleanly, and the browser is left open (as expected).

	Andreas Tolfsen ❲:ato❳
	Comment 3 • 10 years ago

I'm also unable to reproduce this when using `./run.sh`.  The cert program continues after webapirunner exits.