Vittorio Giovara Reporter
	Description • 10 years ago

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140605174243

Steps to reproduce:

Go to about:config. I wanted to press Enter since the "I'll be careful, I promise" is highlighted as the active button.


Actual results:

Pressing Enter didn't trigger the click event on the button


Expected results:

Since the button is the active one I expected that it would be hit when the Enter key was pressed. I am quite sure this was working with older releases of Firefox

	[:Aleksej]
	Comment 1 • 10 years ago

WFM with firefox-30.0.en-US.linux64.

	kenkon
	Comment 2 • 10 years ago

WFM on Win7.

	nemo
	Comment 3 • 10 years ago

Confirmed on OSX Nightly.  WFM on Linux

	nemo
	Comment 4 • 10 years ago

Hm... Maybe it is just that I don't understand how buttons work in OSX?
'cause. This is odd.
Hitting enter does nothing, hitting space works fine.

Another seriously irritating thing encountered fiddling with this.  It is impossible to tab into the elements on the page (keyboard nav).
tab simply switches between url bar and search bar.

Trying to click the radio on/off to focus in-page did nothing to fix this.  Also, if I opened about:config again, such that the confirm button was focused, and hit tab/shift-tab, focus left the button, and no amount of tab/shift-tab would restore it (went to url bar/search bar only).

	nemo
	Comment 5 • 10 years ago

BTW, I'm not sure if the button hitting enter thing, is related to the keyboard navigation, but on the assumption that it is.
Keyboard navigation appears to just be pretty broken in chrome pages. Must suck for people who rely on it.
For example, the new about:preferences is fortunately pretty usable with keyboard navigation on OSX and Linux, but about:addons is essentially unnavigable.

Under OSX, about:addons tabbing only switches between url bar, search bar and search all addons.
Under Linux, you can get to the check for updates menu, but no use of arrow keys,spacebar or enter will get the menu to expand.  You can't get to anything else though, like navigating the main left nav or the addon pref buttons.

So, maybe this is a more general thing about ensuring keyboard navigation works on all chrome pages?
Also, could it be that the new about:preferences is more usable due to using, oh, HTML instead of XUL or something?

P.S. - I despise the fact that I can't add new helper apps in the new about:preferences - drives me nuts.  Made trying to debug a user's problem with an app adding itself as the SVG handler basically impossible, and just irritating if I want a handler of my own for something exotic.

	Stefan [:stefanh]
	Comment 6 • 10 years ago

(In reply to nemo from comment #4)
> Another seriously irritating thing encountered fiddling with this.  It is
> impossible to tab into the elements on the page (keyboard nav).
> tab simply switches between url bar and search bar.

Have you enabled Full Keyboard Access in OS X system prefs?

	nemo
	Comment 7 • 10 years ago

No idea where that is, but don't reallly see why navigation inside the app should require OS settings to behave the same in Linux vs OSX.

	Stefan [:stefanh]
	Comment 8 • 10 years ago

(In reply to Vittorio Giovara from comment #0) 
> Go to about:config. I wanted to press Enter since the "I'll be careful, I
> promise" is highlighted as the active button.

Do you mean that the button has the focus highlight (focus ring around the button) or that the button is blue (which the default button in dialogs is)?

Hitting space on a focused button is equal to a mouse click (see for example http://guides.macrumors.com/Keyboard_shortcuts#Shortcuts_Common_to_Most_Applications). Hitting enter on a default button in a dialog is equal to a mouse click. So, if the button is only focused, this is invalid.

	Vittorio Giovara Reporter
	Comment 9 • 10 years ago

Hi, the button is only focused (blue hue ring around it).
If I press Space it gets selected and clicked correctly, but if I hit Enter nothing happens. I believe that both Enter and Space keys may be used as confirmation (actually I find Space counter intuitive).