Brian Smith (:briansmith, :bsmith, use NEEDINFO?) Reporter
	Description • 10 years ago

Before mozmake, and even during the beta period of the first release of MozillaBuild that included mozmake, one could cancel a build with Ctrl+C and things were silently killed with no dialog boxes.

However, sometime between the (last?) beta of MozillaBuild that added mozmake and the final release, canceling a build in progress with Ctrl+C causes one "mozmake.exe has stopped responding" dialog box to pop up for each spawned mozmake.exe process (often 4+ for me). These dialog boxes only go away when you click their "cancel" button, which you have to do for each one.

	Brian Smith (:briansmith, :bsmith, use NEEDINFO?) Reporter
	Comment 1 • 10 years ago

Minidump showing the access violation (saved in MSVC 2013).

	Ryan VanderMeulen [:RyanVM]
	Comment 2 • 10 years ago

Not sure what we can do about this. Any ideas, Mike?

	Gregory Szorc [:gps]
	Comment 3 • 10 years ago

I believe Ally was seeing mozmake crashes as well.

I don't think this should block the MozillaBuild release unless it's really painful. My perception is its little more than a nuisance. Am I wrong?

	Ryan VanderMeulen [:RyanVM]
	Comment 4 • 10 years ago

I see this too, but yes, it doesn't break anything. Just annoys the crap out of people.

	Kyle Huey (Exited; not receiving bugmail, old account, do not use)
	Comment 5 • 10 years ago

I've seen this once or twice.  What's far more annoying to me is the "zombie" processes that I get sometimes with some broken cl.exe or various other things hanging around.

	Mike Hommey [:glandium]
	Comment 6 • 10 years ago

That sounds related to the fact that some of our python wrappers as we may call them, don't propagate ctrl+c to subprocesses. There is a bug on file about that, but I can't find it right now. So when you ctrl+c your build, mozmake is not killed, and tries to write its output to mach's pipes, which don't exist anymore.

	Jim Mathies [:jimm]
	Comment 7 • 9 years ago

This is a dupe of bug 928983.