Gabriele Svelto [:gsvelto] (PTO) Assignee
	Description • 10 years ago

+++ This bug was initially created as a clone of Bug #1002327 +++

Sending MMI codes when the network is offline will yield a regular USSD message display stating the error that occurred but the title will be missing the SIM number that regular USSD messages get.

	Gabriele Svelto [:gsvelto] (PTO) Assignee
	Comment 1 • 10 years ago

This patch applies on top of attachment 8452999 [details] [diff] [review] and is fairly straightforward in that it adds the SIM number to whatever error message is produced by the MMI/USSD code. This hadn't been done as part of bug 1002327 because I hadn't fully grasped how the MMI/USSD screen was updated.

	Anthony Ricaud (:rik)
	Comment 2 • 10 years ago

Comment on attachment 8453064 [details] [diff] [review]
[PATCH] Add the SIM number to MMI/USSD error messages

Review of attachment 8453064 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good but tests are missing.

	Gabriele Svelto [:gsvelto] (PTO) Assignee
	Comment 3 • 10 years ago

Now with unit-tests aplenty and some linter cleanups to the affected code.

	Anthony Ricaud (:rik)
	Comment 5 • 10 years ago

Comment on attachment 8454363 [details] [diff] [review]
[PATCH v2] Add the SIM number to MMI/USSD error messages

Review of attachment 8454363 [details] [diff] [review]:
-----------------------------------------------------------------

I've left my only comment on Github, sorry.

\o/ for extra testing!

	Gabriele Svelto [:gsvelto] (PTO) Assignee
	Comment 6 • 10 years ago

(In reply to Anthony Ricaud (:rik) from comment #5)
> I've left my only comment on Github, sorry.

Thanks for the review, the this.* constants were coming from the old custom mock mozMobileConnection implementation and I forgot to bring them over. I'll correct that code even though they're not used yet because I still hope to revive the addtional unit-tests sooner or later. I've updated the PR and will wait for a green Try/Travis before merging.

	Gabriele Svelto [:gsvelto] (PTO) Assignee
	Comment 7 • 10 years ago

Try was green, landed on gaia/master 728f9595af428bc2ddc0b1018909ef043aa7fa82

https://github.com/mozilla-b2g/gaia/commit/728f9595af428bc2ddc0b1018909ef043aa7fa82