Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Description • 10 years ago

There are some inconsistencies with how the screen reader volume is updated. It looks like it depends on context. For example: if the screen reader is currently speaking the volume buttons on the Firefox OS device actually update the screen reader volume. However, when nothing is being spoken, the volume buttons have no effect. 

Note: consider accessibility service in Gaia to potentially address this.

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 1 • 10 years ago

This should be handled by the consumer of the accessfu events (Gaia etc).

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 2 • 10 years ago

Fixed up volume related screen reader issues. Added a lot of tests for accessibility.js

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 3 • 10 years ago

Comment on attachment 8465710 [details] [review]
Github pull request.

+1 for accessibility tests. But I don't figure out why the audio.volume.content settings observer is removed and what's the alternative. Could you elaborate more?

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 4 • 10 years ago

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #3)
> Comment on attachment 8465710 [details] [review]
> Github pull request.
> 
> +1 for accessibility tests. But I don't figure out why the
> audio.volume.content settings observer is removed and what's the
> alternative. Could you elaborate more?

Hi Alive, so I think we finally settled on what the screen reader volume actually is. It looks like it is indeed played with content volume and we do not want to change it to change the screen reader volume only. Meaning we want the screen reader volume to always be relative to the content volume. 

So what it means is that we have a accessibility.screenreader-volume settings that fits in [0, 1] values. And the number means its relative volume to the channel volume it plays on (e.g. content). 

So for example if content volume is at 10 and screen reader volume at 0.8, then the screen reader volume on content should be 8. Hopefully this explains it a little bit.

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 5 • 10 years ago

Comment on attachment 8465710 [details] [review]
Github pull request.

I am not sure how could we change 'accessibility.screenreader-volume' but removing content volume observer make sense.

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 6 • 10 years ago

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #5)
> Comment on attachment 8465710 [details] [review]
> Github pull request.
> 
> I am not sure how could we change 'accessibility.screenreader-volume' but
> removing content volume observer make sense.

The setting is available in accessibility settings in the settings app.

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 7 • 10 years ago

https://github.com/mozilla-b2g/gaia/commit/75d12b5d25b153cfd495ae45ac5dcf836e7efa85