Eitan Isaacson [:eeejay] Assignee
	Description • 10 years ago

Double tapping the button does nothing.

	Eitan Isaacson [:eeejay] Assignee
	Comment 1 • 10 years ago

Re-aligning priorities with 2.1 accessibility goals.

	Sergi Mansilla [:sergi] (Telenor) [PTO]
	Comment 3 • 10 years ago

Hi Eitan,

I can't manage to reproduce it; I tap on add image on Contact Edit but it works fine. Can you explain how to reproduce this issue?

Cheers.

	Eitan Isaacson [:eeejay] Assignee
	Comment 4 • 10 years ago

(In reply to Sergi Mansilla (Telenor) from comment #3)
> Hi Eitan,
> 
> I can't manage to reproduce it; I tap on add image on Contact Edit but it
> works fine. Can you explain how to reproduce this issue?
> 
> Cheers.

Hey Sergi,

	Eitan Isaacson [:eeejay] Assignee
	Comment 5 • 10 years ago

Hey Sergi,

I changed the summary to be more accurate. The add image button does not work with the screen reader.
So if you get the cursor to the button (via swiping or explore by touch), and then double tapping, nothing happens.

	Sergi Mansilla [:sergi] (Telenor) [PTO]
	Comment 6 • 10 years ago

Comment on attachment 8455489 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21712

Hi Eitan,

I see, thanks for clarifying. Your code is currently breaking the build, but it looks good once this is solved. Please assign me the review again when you have fixed it.

Thanks!

	Eitan Isaacson [:eeejay] Assignee
	Comment 7 • 10 years ago

Oops, I saw r+ in the PR, so I merged once travis got green!

https://github.com/mozilla-b2g/gaia/commit/fb4ee85188cc9926b82fba11aaabc7452ebbad1d