Closed Bug 1030340 Opened 10 years ago Closed 10 years ago

Add image button does not work with screen reader in contact edit dialog

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

(Keywords: access, Whiteboard: [b2ga11y p=1] )

Attachments

(1 file)

Double tapping the button does nothing.
Re-aligning priorities with 2.1 accessibility goals.
Whiteboard: [b2ga11y p=1]
Assignee: nobody → eitan
Hi Eitan,

I can't manage to reproduce it; I tap on add image on Contact Edit but it works fine. Can you explain how to reproduce this issue?

Cheers.
Flags: needinfo?(eitan)
(In reply to Sergi Mansilla (Telenor) from comment #3)
> Hi Eitan,
> 
> I can't manage to reproduce it; I tap on add image on Contact Edit but it
> works fine. Can you explain how to reproduce this issue?
> 
> Cheers.

Hey Sergi,
Flags: needinfo?(eitan)
Summary: Add image button does not work in contact edit dialog → Add image button does not work with screen reader in contact edit dialog
Hey Sergi,

I changed the summary to be more accurate. The add image button does not work with the screen reader.
So if you get the cursor to the button (via swiping or explore by touch), and then double tapping, nothing happens.
Comment on attachment 8455489 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21712

Hi Eitan,

I see, thanks for clarifying. Your code is currently breaking the build, but it looks good once this is solved. Please assign me the review again when you have fixed it.

Thanks!
Attachment #8455489 - Flags: review?(sergi.mansilla) → review-
Oops, I saw r+ in the PR, so I merged once travis got green!

https://github.com/mozilla-b2g/gaia/commit/fb4ee85188cc9926b82fba11aaabc7452ebbad1d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: