Closed
Bug 1028662
Opened 10 years ago
Closed 10 years ago
IonMonkey: Implement PowHalf Recover Instruction
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: layus, Assigned: layus, Mentored)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
5.22 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
Implement PowHalf in js/src/jit/Recover.cpp. See Bug 1003801 comment 0 for explanation.
Updated•10 years ago
|
Assignee: nobody → layus.on
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Comment 1•10 years ago
|
||
Implement PowHalf Recover Instruction
Attachment #8444095 -
Flags: review?(nicolas.b.pierron)
Comment 2•10 years ago
|
||
Comment on attachment 8444095 [details] [diff] [review] dce-recover-powhalf.patch Review of attachment 8444095 [details] [diff] [review]: ----------------------------------------------------------------- Awesome :) Just a last nit. ::: js/src/jsmath.cpp @@ +662,5 @@ > #if defined(_MSC_VER) > # pragma optimize("g", off) > #endif > bool > +js_math_powhalf_handle(JSContext *cx, HandleValue base, MutableHandleValue result) nit: remove this function, as it is unused.
Attachment #8444095 -
Flags: review?(nicolas.b.pierron) → feedback+
Assignee | ||
Comment 3•10 years ago
|
||
Removed dead code (in anticipation of patch review).
Attachment #8444095 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8444116 -
Flags: review?(nicolas.b.pierron)
Comment 4•10 years ago
|
||
Comment on attachment 8444116 [details] [diff] [review] dce-recover-powhalf.patch Review of attachment 8444116 [details] [diff] [review]: ----------------------------------------------------------------- This sounds good :)
Attachment #8444116 -
Flags: review?(nicolas.b.pierron) → review+
Comment 5•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=d4210b4a8702
https://hg.mozilla.org/mozilla-central/rev/7d12d632c7a3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•