Staś Małolepszy :stas Reporter
	Description • 10 years ago

When bug 994357 lands we will have a much better and secure alternative to explicitly setting innerHTML on translated elements.  This bug will track the removal of all innerHTML uses in translations.

	Zibi Braniecki [:zbraniecki][:gandalf]
	Comment 1 • 9 years ago

SMS refactor landed last week, Settings is in review. It leaves System as the last big one to fix.

	Zibi Braniecki [:zbraniecki][:gandalf]
	Comment 3 • 9 years ago

Comment on attachment 8652056 [details] [review]
[gaia] zbraniecki:1027117-remove-innerHTML-from-l10n > mozilla-b2g:master

We're *that* close to be done with .innerHTML.

	Staś Małolepszy :stas Reporter
	Comment 4 • 9 years ago

Comment on attachment 8652056 [details] [review]
[gaia] zbraniecki:1027117-remove-innerHTML-from-l10n > mozilla-b2g:master

This looks great, thanks Zibi.

I wonder if this is the right moment to also fix the JS code which handled those <spans> in translations:  binding events to them, showing and hiding them etc.  We could add a single span to the source HTML and bind to it, since DOM overlays maintain the identity of elements.

What do you think?

	Zibi Braniecki [:zbraniecki][:gandalf]
	Comment 5 • 9 years ago

Commit: https://github.com/mozilla-b2g/gaia/commit/60b924537fc116e5ff77712985571d70c7b37fb4

	Staś Małolepszy :stas Reporter
	Comment 7 • 9 years ago

This needs to land in l20n.js v2.x.

	Staś Małolepszy :stas Reporter
	Comment 8 • 9 years ago

(In reply to Staś Małolepszy :stas from comment #7)
> This needs to land in l20n.js v2.x.

https://github.com/l20n/l20n.js/commit/1057c621946e96db99ec1fcf4ebeebccf9a97108