Closed
Bug 1027049
Opened 10 years ago
Closed 10 years ago
Remove unused plugin infobar preferences
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 33
People
(Reporter: gfritzsche, Assigned: lviknesh, Mentored)
Details
(Whiteboard: [good first bug] [lang=js])
Attachments
(1 file)
1.30 KB,
patch
|
ttaubert
:
review+
gfritzsche
:
feedback+
|
Details | Diff | Splinter Review |
We have two unused plugin infobar preferences: plugins.hide_infobar_for_blocked_plugin & plugins.hide_infobar_for_outdated_plugin. http://hg.mozilla.org/mozilla-central/annotate/37f08ddaea48/browser/app/profile/firefox.js#l649 We should remove them.
yeah, I am interested to do that.. how can I proceed....???
Flags: needinfo?(georg.fritzsche)
Reporter | ||
Comment 3•10 years ago
|
||
There is a general developer guide here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide If you don't have yet, you should check out the source & build Firefox: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions Comment 0 here describes the lines that need to be removed. Once you have done that, it would be good to confirm that the basic browser tests still run through fine using: > mach mochitest-browser browser/base/content/test/ Then you should create a patch with your changes that you can submit here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch Feel free to contact me via IRC or e-mail if you get stuck.
Flags: needinfo?(georg.fritzsche)
Assignee | ||
Comment 4•10 years ago
|
||
Hope this looks good , can you assign me this bug . Thank you :)
Attachment #8443437 -
Flags: review?(georg.fritzsche)
Reporter | ||
Comment 6•10 years ago
|
||
Comment on attachment 8443437 [details] [diff] [review] plugin-pref.patch This looks fine, thanks. Looking for a peer for an actual r+.
Attachment #8443437 -
Flags: review?(georg.fritzsche) → feedback+
Reporter | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Updated•10 years ago
|
Attachment #8443437 -
Flags: review+
Reporter | ||
Comment 8•10 years ago
|
||
And checked in: https://hg.mozilla.org/integration/fx-team/rev/840334f37ae9
https://hg.mozilla.org/mozilla-central/rev/840334f37ae9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
You need to log in
before you can comment on or make changes to this bug.
Description
•