Ben Francis [:benfrancis] Assignee
	Description • 10 years ago

Peter has asked me to set Google, Yahoo & Bing as search engine options for 2.0 by default to match homescreen search. Currently we just have Google.

	Dale Harvey (:daleharvey)
	Comment 2 • 10 years ago

Slightly confused, this populates the browser database with search engines but we never show the UI for configuring search engines in the browser right? I applied this patch and did a reset-gaia and nothing seemed to change.

Shouldnt we pick up the search provider and icon thats configured in settings?

	Dale Harvey (:daleharvey)
	Comment 3 • 10 years ago

Sorry, wrong Peter

	Ben Francis [:benfrancis] Assignee
	Comment 4 • 10 years ago

We show the dropdown in browser settings when there is more than one search provider specified at build time. It works for me, so I wonder what we are doing differently?

I don't think we can share the setting with the search app because the EverythingMe implementation hard coded inside the search app doesn't have a web-based equivalent that can be used inside the browser.

	Peter Dolanjski [:pdol]
	Comment 5 • 10 years ago

(In reply to Ben Francis [:benfrancis] from comment #4)
> We show the dropdown in browser settings when there is more than one search
> provider specified at build time. It works for me, so I wonder what we are
> doing differently?
> 
> I don't think we can share the setting with the search app because the
> EverythingMe implementation hard coded inside the search app doesn't have a
> web-based equivalent that can be used inside the browser.

This was the thought for 2.0.  We can amalgamate them in 2.1.

	Dale Harvey (:daleharvey)
	Comment 6 • 10 years ago

Comment on attachment 8435914 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20154

Not sure what was up with my previous built but is working now, apologies for the delay.

	Ben Francis [:benfrancis] Assignee
	Comment 7 • 10 years ago

Merged into master https://github.com/mozilla-b2g/gaia/commit/40f66e55044dbb6b882d51cd7bd5ee2548aa2269

	Ben Francis [:benfrancis] Assignee
	Comment 8 • 10 years ago

Comment on attachment 8435914 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20154

[Approval Request Comment]
[User impact] if declined: No choice of search engines in the browser app by default.
[Testing completed]: Manual testing of configuration change, no new functionality added.
[Risk to taking this patch] (and alternatives if risky): Small, just a change of the default configuration requested by Product, no functional changes.
[String changes made]: None.

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 10 years ago

v2.0: https://github.com/mozilla-b2g/gaia/commit/18da069a4e6a806f3076f0dbd7ee16f1f1ce9f6c

	Sue
	Comment 10 • 10 years ago

This issue has been verified successfully on Flame v2.0 & v2.1
Note:
Search engine of Flame 2.0: Browser -> settings
Search engine of Flame 2.1: Settings -> Search
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.0 versions:
Gaia-Rev        f9d6e3d83c3922e9399a6c27f5ce4cdd27bdfd05
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/45112935086f
Build-ID        20141126000203
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141126.032754
FW-Date         Wed Nov 26 03:28:05 EST 2014
Bootloader      L1TC00011880

Flame 2.1 versions:
Gaia-Rev        db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119
Build-ID        20141126001202
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141126.033519
FW-Date         Wed Nov 26 03:35:30 EST 2014
Bootloader      L1TC00011880