Walter Chen[:ypwalter][:wachen] Reporter
	Description • 10 years ago

Build Information

Gaia      d2cfef555dabab415085e548ed44c48a99be5c32
Gecko     https://hg.mozilla.org/mozilla-central/rev/51b428be6213
BuildID   20140605040202
Version   32.0a1
ro.build.version.incremental=96
ro.build.date=Fri May 23 11:17:40 CST 2014

Description
If you picked up a phone and put it in a speaker mode, after hung up the phone call. The second phone call dialed in. It will either be no sound or only ring once.

Steps to Reproduce
1. One phone dialed to target device(flame)
2. Target device picks the phone call up
3. Target device puts the phone call on speaker mode
4. Target device hangs up the phone
5. Another phone call dialed to target device

Expected Results
The ring tone goes on till the limited time or whenever people pick it up

Actual Results
The ring tone rings once or didn't ring at all.

Other Notes

Reproduction Frequency: 100%

	Johan Lorenzo [:jlorenzo]
	Comment 1 • 10 years ago

QA Wanted to see if this issue is reproducible on 1.4.

	Yeojin Chung [:YeojinC]
	Comment 2 • 10 years ago

This issue does NOT occur on the Flame 1.4:

Environmental Variables:
Device: Flame 1.4
Build ID: 20140605145901
Gaia: 183efb374be1bcbf92f1fb3d0212a68b564a6d3e
Gecko: 960c48b5a5fa
Version: 30.0 (1.4) 
Firmware Version: v10G-2

	Jayme Mercado [:JMercado] (Inactive 3/4/2016)
	Comment 3 • 10 years ago

B2g-inbound Regression Window

Last working
Environmental Variables:
Device: Flame
BuildID: 20140528233003
Gaia: eced604040a970e65dfb51fa83e1a18a9d00b7db
Gecko: fe9a8825a3ae
Version: 32.0a1

First Broken
Environmental Variables:
Device: Flame
BuildID: 20140529075121
Gaia: d5dcbabd1ad07d5fd30a7875a9a80817bc93619c
Gecko: f72106cb1769
Version: 32.0a1

Last working gaia / First broken gecko  - Issue DOES occurs
Gaia: eced604040a970e65dfb51fa83e1a18a9d00b7db
Gecko: f72106cb1769

First broken gaia / Last working gecko  - Issue does NOT occur
Gaia: d5dcbabd1ad07d5fd30a7875a9a80817bc93619c
Gecko: fe9a8825a3ae


Gecko Pushlog: hg.mozilla.org/integration/b2g-inbound/pushloghtml?fromchange=fe9a8825a3ae&tochange=f72106cb1769

	Jayme Mercado [:JMercado] (Inactive 3/4/2016)
	Comment 4 • 10 years ago

Corrected link for the Gecko Pushlog above:
http://hg.mozilla.org/integration/b2g-inbound/pushloghtml?fromchange=fe9a8825a3ae&tochange=f72106cb1769

	Jason Smith [:jsmith]
	Comment 5 • 10 years ago

Maybe bug 1006380 broke this?

Jose - What do you think?

	Francisco Jordano [:arcturus] [:francisco]
	Comment 6 • 10 years ago

I know Jose is pretty busy ;) @Maria could you manage to get feedback from him?

Thanks a lot!

	José Antonio Olivera Ortega [:jaoo]
	Comment 7 • 10 years ago

(In reply to Jason Smith [:jsmith] from comment #5)
> Maybe bug 1006380 broke this?
> 
> Jose - What do you think?

Patch from bug 1006380 sets the audio phone state mode to PHONE_STATE_IN_COMMUNICATION when using the telephony audio channel and sets it back to PHONE_STATE_NORMAL when the app finishes using the audio channel. AFAIK There is no relationship with the ringer audio channel not being able to play correctly or just play once. Nevertheless I backed out the patch locally and the issue doesn't reproduce :(

Better to have some feedback from Marco or even Andrea.

	Marco Chen [:mchen]
	Comment 8 • 10 years ago

Hi,

This week, I am on the partner's office so I can't investigate it too much.
I guess that ringer sound is going to receiver (earpiece).

Maybe we can get clue from log of AudioManager::SetPhoneState, AudioManager::SetForceForUse and AudioManager::HandleAudioChannelProcessChanged

	José Antonio Olivera Ortega [:jaoo]
	Comment 9 • 10 years ago

(In reply to Marco Chen [:mchen] (Workshop with Partner 6/16 ~ 6/20) from comment #8)

Thanks for your feedback Marco.

> Maybe we can get clue from log of AudioManager::SetPhoneState,
> AudioManager::SetForceForUse and
> AudioManager::HandleAudioChannelProcessChanged

You're right, I'll provide those logs as soon as possible.

	José Antonio Olivera Ortega [:jaoo]
	Comment 10 • 10 years ago

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #9)
> (In reply to Marco Chen [:mchen] (Workshop with Partner 6/16 ~ 6/20) from
> comment #8)
> 
> Thanks for your feedback Marco.
> 
> > Maybe we can get clue from log of AudioManager::SetPhoneState,
> > AudioManager::SetForceForUse and
> > AudioManager::HandleAudioChannelProcessChanged
> 
> You're right, I'll provide those logs as soon as possible.

There you go.

If you take a look at the logs you see different behaviors. Without backing out patch from bug 1006380 AudioManager::HandleAudioChannelProcessChanged() method calls AudioManager::SetPhoneState(PHONE_STATE_IN_COMMUNICATION) when the user accepts the second incoming call while the ringtone is playing. It seems this causes the ringtone doesn't play correctly. Backing out the patch it doesn't happen, I mean AudioManager::HandleAudioChannelProcessChanged() method doesn't exist and there is no such call to AudioManager::SetPhoneState(PHONE_STATE_IN_COMMUNICATION) and everything works correctly. I've added the logs of a try in which the speakers are not enabled. If the speakers are enabled we see there is a call to AudioManager::SetForceForUse(aUsage(0), aForce(0)) when the device receives the second call and plays the ringtone. The call to SetForceForUse() seems to set the phone audio state to PHONE_STATE_NORMAL which causes AudioManager::HandleAudioChannelProcessChanged() calls AudioManager::SetPhoneState(PHONE_STATE_IN_COMMUNICATION). After noticing this I confirmed that the issue reported in this bug doesn't happen if the speakers are disabled before hanging up the call.

Marco, this is what I see. Your input would be appreciate! Thanks.

PS. Clearing the request at Andrea as we already know what happens here.

	Marco Chen [:mchen]
	Comment 11 • 10 years ago

Hi :jaoo,

Thanks for your investigation and your comments inside file are useful to understand the logs.

> Devices receives a new gsm call
> I/AudioManager(  297): AudioManager::SetPhoneState(PHONE_STATE_RINGTONE)
> I/AudioManager(  297): AudioManager::SetForceForUse(aUsage(0), aForce(0))
> I/AudioManager(  297): AudioManager::SetPhoneState(PHONE_STATE_NORMAL)

As I know AudioManager::SetPhoneState is called by Telephony only, then we may need help from Hsin-Yi.

Hi Hsin-Yi,

It is strange that SetPhoneState will be called for PHONE_STATE_NORMAL during alerting state. Could you help to check it? Thanks.

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 12 • 10 years ago

Hi all,

I just quickly investigated this issue and it turns out that telephony set phone_state as expected. Telephony didn't set phone_state to NORMAL during alerting. 

Please see log snippet below:

=== 1st incoming call ===
06-20 19:13:37.569 I/Gecko   (  498): -*- RadioInterface[0]: Received message from worker: {"rilMessageType":"callStateChange","call":{"state":4,"callIndex":1,"toa":129,"isMpty":false,"isMT":true,"als":0,"isVoice":true,"isVoicePrivacy":false,"number":"","numberPresentation":1,"name":"","namePresentation":1,"uusInfo":null,"isOutgoing":false,"isEmergency":false,"isConference":false},"rilMessageClientId":0}
06-20 19:13:37.569 I/Gecko   (  498): TelephonyService: handleCallStateChange: {"state":4,"callIndex":1,"toa":129,"isMpty":false,"isMT":true,"als":0,"isVoice":true,"isVoicePrivacy":false,"number":"","numberPresentation":1,"name":"","namePresentation":1,"uusInfo":null,"isOutgoing":false,"isEmergency":false,"isConference":false}
=== Set phone_state RINGTONE ===
06-20 19:13:37.599 I/Gecko   (  498): TelephonyService: Put audio system into PHONE_STATE_RINGTONE: 1
=== Accept the call ===
06-20 19:13:42.859 I/Gecko   (  498): -*- RadioInterface[0]: Received message from worker: {"rilMessageType":"callStateChange","call":{"state":0,"callIndex":1,"toa":129,"isMpty":false,"isMT":true,"als":0,"isVoice":true,"isVoicePrivacy":false,"number":"","numberPresentation":1,"name":"","namePresentation":1,"uusInfo":null,"isOutgoing":false,"isEmergency":false,"isConference":false,"started":1403262822866},"rilMessageClientId":0}
06-20 19:13:42.859 I/Gecko   (  498): TelephonyService: handleCallStateChange: {"state":0,"callIndex":1,"toa":129,"isMpty":false,"isMT":true,"als":0,"isVoice":true,"isVoicePrivacy":false,"number":"","numberPresentation":1,"name":"","namePresentation":1,"uusInfo":null,"isOutgoing":false,"isEmergency":false,"isConference":false,"started":1403262822866}
=== Set phone_state IN_CALL ===
06-20 19:13:42.869 I/Gecko   (  498): TelephonyService: Put audio system into PHONE_STATE_IN_CALL: 2
=== Hang up the call ===
06-20 19:13:51.179 I/Gecko   (  498): -*- RadioInterface[0]: Received message from worker: {"rilMessageType":"callDisconnected","call":{"state":0,"callIndex":1,"toa":129,"isMpty":false,"isMT":true,"als":0,"isVoice":true,"isVoicePrivacy":false,"number":"","numberPresentation":1,"name":"","namePresentation":1,"uusInfo":null,"isOutgoing":false,"isEmergency":false,"isConference":false,"started":1403262822866,"hangUpLocal":true,"failCause":"NormalCallClearingError"},"rilMessageClientId":0}
06-20 19:13:51.179 I/Gecko   (  498): TelephonyService: handleCallDisconnected: {"state":0,"callIndex":1,"toa":129,"isMpty":false,"isMT":true,"als":0,"isVoice":true,"isVoicePrivacy":false,"number":"","numberPresentation":1,"name":"","namePresentation":1,"uusInfo":null,"isOutgoing":false,"isEmergency":false,"isConference":false,"started":1403262822866,"hangUpLocal":true,"failCause":"NormalCallClearingError"}
=== Set phone_state NORMAL ===
06-20 19:13:51.339 I/Gecko   (  498): TelephonyService: Put audio system into PHONE_STATE_NORMAL: 3
=== 2nd incoming call ===
06-20 19:14:04.989 I/Gecko   (  498): -*- RadioInterface[0]: Received message from worker: {"rilMessageType":"callStateChange","call":{"state":4,"callIndex":1,"toa":129,"isMpty":false,"isMT":true,"als":0,"isVoice":true,"isVoicePrivacy":false,"number":"","numberPresentation":1,"name":"","namePresentation":1,"uusInfo":null,"isOutgoing":false,"isEmergency":false,"isConference":false},"rilMessageClientId":0}
06-20 19:14:04.989 I/Gecko   (  498): TelephonyService: handleCallStateChange: {"state":4,"callIndex":1,"toa":129,"isMpty":false,"isMT":true,"als":0,"isVoice":true,"isVoicePrivacy":false,"number":"","numberPresentation":1,"name":"","namePresentation":1,"uusInfo":null,"isOutgoing":false,"isEmergency":false,"isConference":false}
=== Set phone_state RINGTONE ===
06-20 19:14:05.019 I/Gecko   (  498): TelephonyService: Put audio system into PHONE_STATE_RINGTONE: 1
=== Remote party released 2nd call ===
06-20 19:14:14.609 I/Gecko   (  498): -*- RadioInterface[0]: Received message from worker: {"rilMessageType":"callDisconnected","call":{"state":4,"callIndex":1,"toa":129,"isMpty":false,"isMT":true,"als":0,"isVoice":true,"isVoicePrivacy":false,"number":"","numberPresentation":1,"name":"","namePresentation":1,"uusInfo":null,"isOutgoing":false,"isEmergency":false,"isConference":false,"failCause":"NormalCallClearingError"},"rilMessageClientId":0}
06-20 19:14:14.609 I/Gecko   (  498): TelephonyService: handleCallDisconnected: {"state":4,"callIndex":1,"toa":129,"isMpty":false,"isMT":true,"als":0,"isVoice":true,"isVoicePrivacy":false,"number":"","numberPresentation":1,"name":"","namePresentation":1,"uusInfo":null,"isOutgoing":false,"isEmergency":false,"isConference":false,"failCause":"NormalCallClearingError"}
=== Set phone_state NORMAL ===
06-20 19:14:14.729 I/Gecko   (  498): TelephonyService: Put audio system into PHONE_STATE_NORMAL: 0

	Tamara Hills [:thills] Assignee
	Comment 13 • 10 years ago

I also noticed the same behaviour as Jose where if I have the following sequence:
1) answer first call
2) go on speaker
3) go off speaker
4) hangup
5) make second inbound call

Then everything rings properly.  Based on that and the feedback from Hsin-Yi that the phone_states are as expected, I made a change to the end() function in calls_handler.js to check if the speaker is enabled before hangup and if it is, just mark speakerEnabled = false.  That fixed it for me (Hamachi).  

Perhaps this is not the best place to fix it so I'll keep looking to see if there is another place where it should be turned off.

	Tamara Hills [:thills] Assignee
	Comment 14 • 10 years ago

This is a log without the INCOMMUNICATION change and with it.  I also filtered out the rpc_snd_set_device calls and noticed that with the change as soon as the INCOMMUNICATION state is set, it's sending an extra call to rpc_snd_set_device (which is not there without the patch).  Looks like this call to rpc_send_set_device(0,1,0) can be changing the output.  I'm trying to track back from the Audiohardware back to the AudioManager to see what's causing this.

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 15 • 10 years ago

Per discussion with Marco, we believe the root cause is in [1] and [2]. 
Bug 749794 added these two lines because there was a forced phone setting to IN_CALL or IN_COMMUNICATION to make speaker/microphone work, and we needed to set the phone state back to NORMAL if there's no active call (see bug 749794 comment 10). Then Bug 790570 removed the forced assignment without clearing [1] and [2].

Since after bug 790570, we don't force phone state to IN_CALL or IN_COMMUNICATION, we should be safe to remove [1] and [2] now.
 
[1] http://dxr.mozilla.org/mozilla-central/source/dom/telephony/gonk/TelephonyService.js?from=TelephonyService.js&case=true#671
[2] http://dxr.mozilla.org/mozilla-central/source/dom/telephony/gonk/TelephonyService.js?from=TelephonyService.js&case=true#653

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 16 • 10 years ago

Hi Tamara,

I think it's a gecko bug, please see comment 15. Not sure if you are still going to work on gecko side. If yes, I am happy to provide any assistance; if not, feel free to assign to me. Thank you. :)

	Marco Chen [:mchen]
	Comment 17 • 10 years ago

Comment on attachment 8443075 [details]
1021550-log.txt

Already give response in comment 11 and discussed with Hsin-Yi in comment 15

	Tamara Hills [:thills] Assignee
	Comment 18 • 10 years ago

Hi Hsin-Yi,

I tried out your suggested change and it fixes it for me...  If it's ok, I'd like to continue to work on it since I'm trying to get spun up in this area.  If I could take your advice on what test suites I should run, that would be great.

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 19 • 10 years ago

(In reply to Tamara Hills from comment #18)
> Hi Hsin-Yi,
> 
> I tried out your suggested change and it fixes it for me...  If it's ok, I'd
> like to continue to work on it since I'm trying to get spun up in this area.

No problem, all yours :)

> If I could take your advice on what test suites I should run, that would be
> great.
We need to run marionette-webapi test. And I am thinking about to add a new marionette test to catch this issue.

In that new test, we will need to call mozTelephony.speakerEnabled() API to set speaker enabled in different telephony call state. And we also need to check that toggling speakerEnabled doesn't change nsIAudioManager.phoneState.

You could refer to dom/telephony/test/marionette/test_audiomanager_phonestate.js and /test_call_mute.js for some ideas! 

Let me know if anything I could help. :)

	Tamara Hills [:thills] Assignee
	Comment 20 • 10 years ago

Hi Hsinyi, I'm seeing that the removing the check set the phone state back to normal when there are no active calls is breaking the test_audiomanager_callstate.js.  Essentially, there is a check
where it expects it to be in NORMAL state, but it's actually in RINGTONE (since we removed the code to set it to NORMAL).  There is also this note in the test about 948860 and whether it should be expecting RINGTONE due to the UX implications.

Wanted to get your feedback on changing this test as to whether there could be some other complication.

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 21 • 10 years ago

Comment on attachment 8446943 [details] [diff] [review]
WIP 1021550

Review of attachment 8446943 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 22 • 10 years ago

(In reply to Tamara Hills from comment #20)
> Created attachment 8446943 [details] [diff] [review]
> WIP 1021550
> 
> Hi Hsinyi, I'm seeing that the removing the check set the phone state back
> to normal when there are no active calls is breaking the
> test_audiomanager_callstate.js.  Essentially, there is a check
> where it expects it to be in NORMAL state, but it's actually in RINGTONE
> (since we removed the code to set it to NORMAL).  There is also this note in
> the test about 948860 and whether it should be expecting RINGTONE due to the
> UX implications.
> 
> Wanted to get your feedback on changing this test as to whether there could
> be some other complication.

I think bug 948860 is a duplicate of this bug. These two both are talking about the same thing. And your change to test_audiomanager_callstate.js makes sense.

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 23 • 10 years ago

Comment on attachment 8446943 [details] [diff] [review]
WIP 1021550

Review of attachment 8446943 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

::: dom/telephony/test/marionette/test_audiomanager_phonestate.js
@@ +62,5 @@
>      .then(call => { inCall = call; })
>      // TODO - Bug 948860: should this be {RINGTONE, RINGTONE, RINGTONE}?
>      // From current UX spec, there is no chance that an user may enable speaker
>      // during alerting, so basically this 'set speaker enable' action can't
>      // happen in B2G.

Once you fix this, please also remove this TODO comment.

	Tamara Hills [:thills] Assignee
	Comment 25 • 10 years ago

Updated patch.  Link to the try:  https://tbpl.mozilla.org/?tree=Try&rev=9aea51f0774b

	Tamara Hills [:thills] Assignee
	Comment 26 • 10 years ago

Test case to handle the sequence of steps to repro this issue.  Basically,
* Receive an incoming call
* Put the phone on speaker
* Hang up without user turning off speaker
* Receive second incoming call

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 27 • 10 years ago

Comment on attachment 8448439 [details] [diff] [review]
1021550

Review of attachment 8448439 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thank you.

The commit message isn't right for check-in. Please don't forget to modify the commit comment according to https://developer.mozilla.org/en-US/docs/Mozilla/Projects/L20n/Contribute#Adjust_the_commit_message

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 28 • 10 years ago

Comment on attachment 8448444 [details]
test_incomingcall_phonestate_speaker.js

This is not a patch format. Please upload a correct one again. Also, after adding a new test case, you will need to revise a corresponding manifest.ini, e.g. dom/telephony/test/marionette/manifest.ini, correspondingly.

	Tamara Hills [:thills] Assignee
	Comment 29 • 10 years ago

Hi Hsin-Yi, I put everything together in one patch file (including the test and the update to the manifest.ini).  Let me know if that's the correct process.  Also, I updated the commit message...  I can update it again once I have your review to show that you reviewed.  Thank you!

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 30 • 10 years ago

Comment on attachment 8448709 [details] [diff] [review]
Updated patch with test included and new commit msg.

Review of attachment 8448709 [details] [diff] [review]:
-----------------------------------------------------------------

This looks really good! Only some minor comments and nits. I'll give r+ after they are addressed, thank you for the work :)

::: dom/telephony/test/marionette/test_incomingcall_phonestate_speaker.js
@@ +16,5 @@
> +
> +let audioManager;
> +
> +function checkSpeakerEnabled(phoneStatePrev, phoneStateNew, toggle, setSpeaker) {
> +    if (!audioManager) {

Use 2-space indentation over the file.

@@ +21,5 @@
> +        audioManager = SpecialPowers.Cc[AUDIO_MANAGER_CONTRACT_ID]
> +            .getService(SpecialPowers.Ci.nsIAudioManager);
> +        ok(audioManager, "nsIAudioManager instance");
> +    }
> +

You got two empty lines here. Please remove one.

@@ +23,5 @@
> +        ok(audioManager, "nsIAudioManager instance");
> +    }
> +
> +
> +    ok(audioManager.phoneState === phoneStatePrev, "audioManager.phoneState");

Let's use |is(audioManager.phoneState, phoneStatePrev, "audioManager.phoneState");|

@@ +27,5 @@
> +    ok(audioManager.phoneState === phoneStatePrev, "audioManager.phoneState");
> +    if(toggle) {
> +      telephony.speakerEnabled = setSpeaker;
> +    }
> +    ok(audioManager.phoneState === phoneStateNew, "audioManager.phoneState");

ditto.

@@ +45,5 @@
> +    .then(() => checkSpeakerEnabled(PHONE_STATE_RINGTONE, PHONE_STATE_RINGTONE, false, false))
> +    .then(() => gAnswer(inCall))
> +    .then(() => checkSpeakerEnabled(PHONE_STATE_IN_CALL, PHONE_STATE_IN_CALL, false, false))
> +    // Go on Speaker (Don't go off speaker before hanging up.  This is to check
> +    // the condition for 1021550)

nit: s/1021550/bug 1021550/

@@ +52,5 @@
> +    .then(() => gRemoteHangUp(inCall))
> +    .then(() => checkSpeakerEnabled(PHONE_STATE_NORMAL, PHONE_STATE_NORMAL, false, false))
> +    // Make a second inbound call
> +    .then(() => gRemoteDial(inNumber))
> +    .then(call => { inSecondCall = call; })

We could reuse the variable 'inCall' as we don't have two calls at the same time. Please remove the variable 'inSecondCall' thanks!

	Tamara Hills [:thills] Assignee
	Comment 31 • 10 years ago

Hi Hsin-Yi, thanks for the review.  I think I've got everything in this one now.  Thanks.

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 32 • 10 years ago

Comment on attachment 8449371 [details] [diff] [review]
Updates to the patch with Hsin-Yi's last comments

Review of attachment 8449371 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!  Thank you for the work. r=me with the comment addressed.

If you don't have level-3 privilege, please upload a final patch with all required information in commit message and put keyword "checkin-needed" so that anyone authorized could help you land the patch. Thank you again :)

::: dom/telephony/test/marionette/test_incomingcall_phonestate_speaker.js
@@ +55,5 @@
> +    .then(() => checkSpeakerEnabled(PHONE_STATE_RINGTONE, PHONE_STATE_RINGTONE, false, false))
> +    .then(() => gAnswer(inCall))
> +    .then(() => checkSpeakerEnabled(PHONE_STATE_IN_CALL, PHONE_STATE_IN_CALL, false, false))
> +    // Hang up the call
> +    .then(() => gRemoteHangUpCalls([inCall]))

Using gRemoteHangUp(inCall) is enough.

	Tamara Hills [:thills] Assignee
	Comment 33 • 10 years ago

Final patch which needs checkin.  There is an updated try run as well:
https://tbpl.mozilla.org/?tree=Try&rev=4ca1e399b579

	Tamara Hills [:thills] Assignee
	Comment 34 • 10 years ago

Added the checkin-needed in the commit message.

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 35 • 10 years ago

(In reply to Tamara Hills [:thills] from comment #34)
> Created attachment 8451205 [details] [diff] [review]
> Final patch -- added checkin-needed in the commit message
> 
> Added the checkin-needed in the commit message.

Hey, Tamara,

Thanks for the final patch :)
Just want to double confirm: is this patch ready for check-in? If yes, I could do that for you. But next time, please add "checkin-needed" in "Keywords" plank! Sorry that I seemed not explain clear enough :)

	Tamara Hills [:thills] Assignee
	Comment 36 • 10 years ago

Hi Hsin-Yi,

Yes, it's ready.  That would be great.

Thanks,
-tamara

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 37 • 10 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/90fde19681b9

	Carsten Book [:Tomcat]
	Comment 38 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/90fde19681b9

	Ryan VanderMeulen [:RyanVM]
	Comment 39 • 10 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/4272b20e0667

	Lancy(Leave from Mozilla)
	Comment 40 • 10 years ago

This issue has been verified successfully on Flame 2.0 &2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10

Flame v2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141202000201
Version         32.0

Flame v2.1 version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0