Closed
Bug 1018214
Opened 10 years ago
Closed 10 years ago
Write Gaia-ui accessibility tests for the utility tray.
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yzen, Assigned: yzen)
References
Details
(Keywords: access)
Attachments
(1 file, 2 obsolete files)
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
We need test for the utility tray visibility and the open and closed states.
Blocks: 994701
Summary: Write → Write Gaia-ui accessibility tests for the utility tray.
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8432706 -
Flags: review?(zcampbell)
|
|
Assignee | |
Updated•10 years ago
|
Component: Gaia → Gaia::UI Tests
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8432706 [details] [review] Github PR Asking Bebe to review
Attachment #8432706 -
Flags: review?(zcampbell) → review?(florin.strugariu)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8432706 [details] [review] Github PR There are some nit's there before this can be merged
Attachment #8432706 -
Flags: review?(florin.strugariu) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8432706 [details] [review] Github PR Asking for a quick re-review as I modified a11y_wheel_utility_tray_grippy method in utility_tray.py to account for transition when hiding the overlay.
Attachment #8432706 -
Flags: review+ → review?(florin.strugariu)
Flags: needinfo?(florin.strugariu)
|
|
||
Updated•10 years ago
|
Attachment #8432706 -
Flags: review?(florin.strugariu) → review+
Flags: needinfo?(florin.strugariu)
|
|
||
Comment 6•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/371cd00ddd0a8242744a810a932490889a2f3df8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 7•10 years ago
|
||
Unfortunately I've had to revert this for intermittent test failures: https://tbpl.mozilla.org/php/getParsedLog.php?id=41214134&tree=B2g-Inbound https://github.com/mozilla-b2g/gaia/commit/8689f61409f07ad6c7646299326993124a0c309a
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 8•10 years ago
|
||
Original pull request + it includes the pull request for bug 1021710 as a separate commit.
Attachment #8432706 -
Attachment is obsolete: true
Attachment #8435947 -
Flags: review?(zcampbell)
|
|
||
Comment 9•10 years ago
|
||
Comment on attachment 8435947 [details] [review] Github PR Viorela, can you take this review for me? As it has failed with stability problems in the past it should be run 50-100 times locally to check its stability. Thanks!
Attachment #8435947 -
Flags: review?(zcampbell) → review?(viorela.ioia)
|
||
Comment 10•10 years ago
|
||
Comment on attachment 8435947 [details] [review] Github PR Looks good!
Attachment #8435947 -
Flags: review?(viorela.ioia) → review+
|
|
Assignee | |
Comment 11•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/fe4842aa5af8bdb432c10ad10b41d2c97a2894bc
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
|
||
Comment 12•10 years ago
|
||
Reverted for causing test-failures on travis. You had a green travis PR, but maybe something changed before the run and landing? https://github.com/mozilla-b2g/gaia/commit/259f517689d26e3b6099a97be5696453e27ac2ed TEST-START test_a11y_utility_tray_visibility.py test_a11y_utility_tray_visibility (test_a11y_utility_tray_visibility.TestUtilityTrayVisibilityAccessibility) ... FAIL ====================================================================== FAIL: None ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/travis/build/mozilla-b2g/gaia/travis_venv/local/lib/python2.7/site-packages/marionette_client-0.7.9-py2.7.egg/marionette/marionette_test.py", line 170, in run testMethod() File "/home/travis/build/mozilla-b2g/gaia/tests/python/gaia-ui-tests/gaiatest/tests/accessibility/system/test_a11y_utility_tray_visibility.py", line 30, in test_a11y_utility_tray_visibility self.assertFalse(self.accessibility.is_hidden(utility_tray_container)) TEST-UNEXPECTED-FAIL | test_a11y_utility_tray_visibility.py test_a11y_utility_tray_visibility.TestUtilityTrayVisibilityAccessibility.test_a11y_utility_tray_visibility | AssertionError: True is not false ---------------------------------------------------------------------- Ran 1 test in 11.388s FAILED (failures=1)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 13•10 years ago
|
||
Comment on attachment 8435947 [details] [review] Github PR Added accessibility.is_visible for more stability, travis looks good now: https://travis-ci.org/mozilla-b2g/gaia/builds/27696529
Attachment #8435947 -
Flags: review+ → review?(zcampbell)
|
|
||
Comment 14•10 years ago
|
||
Comment on attachment 8435947 [details] [review] Github PR Bebe will take this.
Attachment #8435947 -
Flags: review?(zcampbell) → review?(florin.strugariu)
|
|
Assignee | |
Comment 15•10 years ago
|
||
Comment on attachment 8435947 [details] [review] Github PR https://github.com/mozilla-b2g/gaia/pull/20508
|
|
Assignee | |
Comment 16•10 years ago
|
||
Attachment #8435947 -
Attachment is obsolete: true
Attachment #8435947 -
Flags: review?(florin.strugariu)
Attachment #8443492 -
Flags: review?(florin.strugariu)
|
|
||
Updated•10 years ago
|
Attachment #8443492 -
Flags: review?(dave.hunt)
|
|
||
Updated•10 years ago
|
Attachment #8443492 -
Flags: review?(florin.strugariu) → review+
|
|
||
Comment 17•10 years ago
|
||
As I'm not a JS expert I asked Dave to take a looks over the Js part of the pull
|
||
Updated•10 years ago
|
Attachment #8443492 -
Flags: review?(dave.hunt) → review+
|
|
||
Comment 18•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/002c73b3de9ed5f217e6d24b50abec255da71de0
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•