Kim Moir [:kmoir] ET Assignee
	Description • 10 years ago

Now that we have tests running on emulators, we can disable selected tests running on tegras

See https://bugzilla.mozilla.org/show_bug.cgi?id=971176#c4 for more details
on what can be disabled

summary:
change should ride the trains
leave robocop and media mochitests running on 2.2 (media mochitests correspond to M2-M4)
all other 2.2 opt tests should be disabled including talos

	Kim Moir [:kmoir] ET Assignee
	Comment 1 • 10 years ago

Here is the patch to disable the specified non-talos opt tests on tegras and ride the trains.  I'll also attach the builder diff.   

To disable the talos tests, I couldn't find a working solution that would only disable tests on a specific branch and platform.  I tried it like this

BRANCHES[branch][suite] = (1, False, TALOS_REMOTE_FENNEC_OPTS, ANDROID)

but this disables it for both panda and tegra, which is not what we want.  Do you have any suggestions on how to approach this?

	Kim Moir [:kmoir] ET Assignee
	Comment 2 • 10 years ago

builder diff

	Aki Sasaki (not active)
	Comment 3 • 10 years ago

Comment on attachment 8431046 [details] [diff] [review]
bug1017599.patch

>+# bug 1017599 disable most tegra tests on trunk and let this ride the trains 
>+for name, branch in items_at_least(BRANCHES, 'gecko_version', 33):

m-c is currently 32, and will be until june 9.
Let's set this to at least 32.

ESR will be off 31, but we also don't have mobile on ESRs, so aiui setting this to 32 will let us kill tegras in 3 merge days' time.

	Aki Sasaki (not active)
	Comment 4 • 10 years ago

(In reply to Aki Sasaki [:aki] from comment #3) 
> ESR will be off 31, but we also don't have mobile on ESRs, so aiui setting
> this to 32 will let us kill tegras in 3 merge days' time.

Er, as long as we fix the tests we're still running to run on emulators.

	Kim Moir [:kmoir] ET Assignee
	Comment 5 • 10 years ago

Comment on attachment 8431046 [details] [diff] [review]
bug1017599.patch

but changed to version of gecko to 32

	Kim Moir [:kmoir] ET Assignee
	Comment 6 • 10 years ago

I looked at this again and couldn't find a way to disable the talos tests on a single platform (tegras) and branch since talos tests are enabled on a per branch basis.  I think the best thing to do would be to just disable the talos tests on tegras when they are decommissioned.  This is easy to do by removing the tegra_android from this line in mobile_config.py

ANDROID = ["panda_android", "tegra_android"]

	Chris Cooper [:coop] (he/him)
	Comment 7 • 10 years ago

Merged to production and deployed.

	Kim Moir [:kmoir] ET Assignee
	Comment 8 • 10 years ago

verified on tbpl 

gbrown let me know when there are other tests that are ready to disable