Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Description • 10 years ago

We've got a bunch of code and the code quality is ok, but probably not great. It'd be nice to have a script (and possibly a git pre-commit hook) that runs the code (or changes) through a bunch of linting for style issues so that our style can remain consistent without a lot of effort or back-and-forth in PRs.

This bug covers:

1. setting up such things (maybe re-use what Kitsune has?)
2. going through the existing code and fixing style issues

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 1 • 10 years ago

Pushing this off to 2014q3.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 2 • 10 years ago

analytics app: https://github.com/mozilla/fjord/commit/ed2923fe

base app: https://github.com/mozilla/fjord/commit/afdfc6a

feedback app: https://github.com/mozilla/fjord/commit/05e0a331

heartbeat app: https://github.com/mozilla/fjord/commit/3d9bc26f

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 3 • 10 years ago

The rest of the cosmetic changes from linting and a script and a pre-commit hook all in PR: https://github.com/mozilla/fjord/pull/339

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 4 • 10 years ago

This is still missing baked (or tariff) and jshint linting.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 5 • 10 years ago

PR 339 landed in master in: https://github.com/mozilla/fjord/commit/2f212c5efafac0e7a07187ed21b50d9884de8a02

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 6 • 10 years ago

I just bumped this to 2014q4, but then I thought better of that. Instead, I'm going to reduce the scope of this to just the flake8 stuff and create new bugs for tariff and jshint.