Closed
Bug 1009968
Opened 10 years ago
Closed 10 years ago
IonMonkey: Implement Lsh Recover Instruction
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: nbp, Assigned: jlevesy)
References
(Blocks 1 open bug)
Details
(Whiteboard: [good first bug][mentor=nbp][lang=c++])
Attachments
(1 file, 2 obsolete files)
5.14 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
Implement RBitLsh in js/src/jit/Recover.cpp. See Bug 1003801 comment 0 for explanation.
Assignee | ||
Comment 1•10 years ago
|
||
Hi Nicolas. I'm interested in working on this.
Assignee | ||
Comment 2•10 years ago
|
||
Here's a first attempt, with tests on number and object cases. I ran suite locally. Everything is green on my setup. Thanks for review ! :)
Attachment #8423357 -
Flags: review?(nicolas.b.pierron)
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → jlevesy
Reporter | ||
Comment 3•10 years ago
|
||
Comment on attachment 8423357 [details] [diff] [review] 1009968 Implemented RBitLsh recover operation Review of attachment 8423357 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jit/Recover.h @@ +19,5 @@ > #define RECOVER_OPCODE_LIST(_) \ > _(ResumePoint) \ > _(BitNot) \ > _(BitOr) \ > + _(BitLsh) \ Sorry, my mistake, this is Lsh, and not BitLsh, as the MIR Instruction name.
Attachment #8423357 -
Flags: review?(nicolas.b.pierron) → feedback+
Assignee | ||
Comment 4•10 years ago
|
||
No problem, here's an update with full rename. Thanks :)
Assignee | ||
Updated•10 years ago
|
Attachment #8423357 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8423690 -
Flags: review?(nicolas.b.pierron)
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8423690 [details] [diff] [review] 1009968 Implemented RLsh recover operation Review of attachment 8423690 [details] [diff] [review]: ----------------------------------------------------------------- This patch is good, but Your patch is based on an out-dated version of mozilla-central, rebase your changes and resolve the merge conflicts, if any. Follow the order defined in Bug 1003801 comment 0, such as we have consistency across all files.
Attachment #8423690 -
Flags: review?(nicolas.b.pierron) → feedback+
Assignee | ||
Comment 6•10 years ago
|
||
Here it is, rebased and reorganized :)
Attachment #8423690 -
Attachment is obsolete: true
Attachment #8427641 -
Flags: review?(nicolas.b.pierron)
Reporter | ||
Updated•10 years ago
|
Attachment #8427641 -
Flags: review?(nicolas.b.pierron) → review+
Reporter | ||
Comment 7•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=be3bcda83ef7
Reporter | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Comment 8•10 years ago
|
||
I've pushed the patch to mozilla-inbound: [hg] https://hg.mozilla.org/integration/mozilla-inbound/rev/ca15242af3a3 [tbpl] https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=ca15242af3a3 Note that I had to modify the title of the patch to follow the commit guideline[1]. [1] https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ca15242af3a3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•