Punam Dahiya [:pdahiya] Assignee
	Description • 10 years ago

With Bug 959197, Gaia-Ui-tests are updated to change platform to platformName at https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/gaia_test.py#L652

With this change b2gperf fails for older builds (e.g. m-c BuildId 20131211040203)

	Punam Dahiya [:pdahiya] Assignee
	Comment 1 • 10 years ago

Submitting the patch with the fix. Please review. Thanks!

	Andreas Tolfsen ❲:ato❳
	Comment 2 • 10 years ago

Comment on attachment 8416784 [details] [review]
PR with fix of Bug 1005377

LGTM, but please add a comment about why we're adding it.  Please carry on r+ when added.

	Punam Dahiya [:pdahiya] Assignee
	Comment 3 • 10 years ago

Thanks Andreas, there is an error seen in master builds after jan30. Updated github with the details. Please provide your inputs. Thanks

	Zac C (:zac)
	Comment 4 • 10 years ago

Comment on attachment 8416784 [details] [review]
PR with fix of Bug 1005377

I think you should just pin to the old version of gaiatest, or update it to suit the new marionette server change.

	Dave Hunt [:davehunt] [he/him] ⌚BST
	Comment 5 • 10 years ago

In order to do as suggested in comment 4 (pin to old version), you would first need to determine the marionette client version compatible with the build you're attempting to test against. Then, you would need to dig into which version of gaiatest depended on this marionette client version. Then, you would need to either determine which version of b2gperf depended on that gaiatest version or you could use the latest b2gperf and install the appropriate gaiatest version, but you may still find incompatibilities. Unfortunately there's no good answer here, and the question of whether (or how long) to support older builds in these packages is still being discussed.

Out of curiosity, why are you trying to run b2gperf against this older build? It's interesting to know you have this requirement, and very useful to understand the use cases.

	Punam Dahiya [:pdahiya] Assignee
	Comment 6 • 10 years ago

Video cold launch time has regressed in 1.4 and the main reason has been narrowed to tablet media query changes that landed in Dec last year (Bug 1002842). My use case is to measure cold launch time of video app before and after tablet changes. Thanks

	Zac C (:zac)
	Comment 7 • 10 years ago

I spoke to @pdahiya in #gaia and he has an appropriate workaround to this, he's not blocked.

We (teams who work on Marionette/gaiatest) discussed what caused this at a higher level and how difficult it is to fix now. We've raised https://bugzilla.mozilla.org/show_bug.cgi?id=1008234 to fix it properly for the future so this kind of issue is much less likely to come up.

	Andreas Tolfsen ❲:ato❳
	Comment 8 • 10 years ago

One possible option is to use get(key, fallback) function on the "platform" capability to alternate between "platform" and "platformName" depending on which is available.  That would save us from rolling back the patch for bug 1008234.