David Bolter [:davidb] (NeedInfo me for attention) Reporter
	Description • 10 years ago

This is the sighted keyboard user use case.

(I tested on OSX with the following system setting:
System Preferences -> Keyboard -> Shortcuts -> at bottom under "Full Keyboard Access "All controls" is selected)

STR:
1. go to about:accounts (type that into location bar)
2. confirm you see a page that says "Welcome to Sync"
3. repeated press [tab] key to see where focus cycles.

Expected:
The "Manage" button should get focus at some point.

Actual:
It doesn't get focus.

	David Bolter [:davidb] (NeedInfo me for attention) Reporter
	Comment 1 • 10 years ago

This also applies to when you see the "Get Started" button instead.

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 2 • 10 years ago

Might be helped by bug 998051?

	Karl Thiessen [:kthiessen, he/him]
	Comment 3 • 9 years ago

:davidb, do you have any opinion on whether we should continue to block accessibility-review of FxA on this bug?  It's not looking like anyone is going to get to this soon; bug 996243 has now been open for nearly a year, and we have millions of FxA's in the wild.  I'm rather at a loss for what the next step should be.

Thanks very much for any guidance.

	David Bolter [:davidb] (NeedInfo me for attention) Reporter
	Comment 4 • 9 years ago

Well, it needs to be fixed before it passes review. This might be as simple as setting an attribute tabindex="0" in:
<a id="buttonGetStarted" class="button" href="#">
in aboutaccounts.xhtml

	Marco Zehe (:MarcoZ)
	Comment 5 • 9 years ago

FWIW, I cannot reproduce this bug on Windows in Nightly. The Manage button does get focus for me. I just don't know if it is indicated visually. If so, the only thing needed might be an adjustment to the CSS for :focus of that element. An a with any kind of href should get focus in any case, the only a tags that don't are those that create a named anchor.

	David Bolter [:davidb] (NeedInfo me for attention) Reporter
	Comment 6 • 9 years ago

It would be good if someone else can try to reproduce based on my STR (on OSX)... If that fails I'll dig deeper into why this still reproduces for me.

	Marco Zehe (:MarcoZ)
	Comment 7 • 9 years ago

OK, I could reproduce this on OS X, but definitely not on Windows.

Wonder if it is the about:config pref (which I currently don't know the name of) that overrides the tab key behavior on OS X, or not, depending on what it's set to? This has been the cause for headaches with keyboard users in the past ever since we introduced that. Could this just be another case?

	Yura Zenevich [:yzen] (please use "needinfo")
	Comment 8 • 9 years ago

I can reproduce it on the mac as well, and tabindex="0" does fix the issue.

	Karl Thiessen [:kthiessen, he/him]
	Comment 9 • 9 years ago

Submitted https://github.com/mozilla/fxa-content-server/issues/2049 -- will update here when I get news.

	Chris Karlof [:ckarlof]
	Comment 10 • 9 years ago

The "Manage" and "Getting Started" are buttons that ship with Firefox. They aren't managed by the content server.

	Chris Karlof [:ckarlof]
	Comment 11 • 9 years ago

Here's the relevant file: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/aboutaccounts/aboutaccounts.xhtml

	Karl Thiessen [:kthiessen, he/him]
	Comment 12 • 9 years ago

Thank you, :ckarlof.  This seems like a quick fix; is there anyone on the cc list for this bug who has a moment to implement it?

	Chris Karlof [:ckarlof]
	Comment 13 • 9 years ago

In IRC, it looks like :vlad was interested in helping out.

	Vlad Filippov (:vladikoff) Assignee
	Comment 14 • 9 years ago

Besides setting `tabindex` we also need to convert the anchors to buttons to make them actionable (using SPACE or ENTER keys). 
Demo: http://vf.io/i/bugzilla1005085-d4a.gif

	Karl Thiessen [:kthiessen, he/him]
	Comment 15 • 9 years ago

Comment on attachment 8552108 [details] [diff] [review]
0001-bug-1005085-Fixes-about-accounts-keyboard-navigation.patch

Review of attachment 8552108 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not a module owner or a peer here, but this patch does what it's supposed to, consistent with my knowledge.

	Chris Karlof [:ckarlof]
	Comment 16 • 9 years ago

:jgruen is going to take a look.

	Vlad Filippov (:vladikoff) Assignee
	Comment 17 • 9 years ago

Try Build results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=98c285dfdf65
Linux Build Available here: https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/vlad@vladikoff.com-98c285dfdf65/try-linux/

	John Gruen [:jgruen]
	Comment 18 • 9 years ago

Built Vlad's patch on OSX, LGTM!

	Carsten Book [:Tomcat]
	Comment 19 • 9 years ago

https://hg.mozilla.org/integration/fx-team/rev/e41ae9819719

	Ryan VanderMeulen [:RyanVM]
	Comment 20 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/e41ae9819719