Mats Palmgren (inactive) Assignee
	Description • 10 years ago

+++ This bug was initially created as a clone of Bug #1000431 +++

At the same time we should also remove:
https://hg.mozilla.org/mozilla-central/diff/3038a5a34a75/testing/profiles/prefs_general.js

	Mats Palmgren (inactive) Assignee
	Comment 1 • 9 years ago

All the listed blocking bugs now have patches (some still pending review).
So I think we're ready to enable Grid in Nightly and Developer Edition builds,
as soon as those lands.

	Mats Palmgren (inactive) Assignee
	Comment 2 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6078c45e70cd

	Daniel Holbert [:dholbert]
	Comment 3 • 9 years ago

(In reply to Mats Palmgren (:mats) from comment #0)
> At the same time we should also remove:
> https://hg.mozilla.org/mozilla-central/diff/3038a5a34a75/testing/profiles/prefs_general.js

Note: the patch is missing this suggested testing/profiles/prefs_general.js tweak. But I think that's correct, because we'll still need this line for release builds (or else tests would start failing there when this bug's patch got merged to a RELEASE_BUILD).

	Mats Palmgren (inactive) Assignee
	Comment 4 • 9 years ago

I think we can (and should) remove that bit from the testing profile actually.
Why would tests start failing without it?

	Daniel Holbert [:dholbert]
	Comment 5 • 9 years ago

Sorry, I should've said "might start failing" (if we have tests that assume grid is enabled -- which we could have, but maybe/probably we don't)

r=me with the testing profile tweak added, as long as you've verified that tests pass with that (and without the all.js pref-flip).  

(Might really be better to land the testing profile tweak first, as its own patch, so that we get a full TreeHerder cycle with the test-profile pref-enabled configuration that we'll end up having on Release.  But I suppose a Try run of just that tweak would do too.)

	Mats Palmgren (inactive) Assignee
	Comment 6 • 9 years ago

Actually, it's probably better to leave that as is so that we have test coverage
for Grid on those channels too, even though it's not enabled by default (the Grid
test manifest enables it unconditionally for those tests at least).

We can remove it at the same time we let it ride the trains.
I filed bug 1217086 and made a note there so we don't forget.

	Mats Palmgren (inactive) Assignee
	Comment 7 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/282e4426f1e1

	Carsten Book [:Tomcat]
	Comment 8 • 9 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/282e4426f1e1

	Carsten Book [:Tomcat]
	Comment 9 • 9 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/282e4426f1e1

	Carsten Book [:Tomcat]
	Comment 10 • 9 years ago

(In reply to Carsten Book [:Tomcat] from comment #9)
> https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/282e4426f1e1

backed this out on request from mats from b2g v2.5 in http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/0869ace8c965