Closed Bug 998726 Opened 10 years ago Closed 10 years ago

quell the django 1.5 deprecation warnings

Categories

(Input Graveyard :: Code Quality, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

References

Details

(Whiteboard: u=dev c=codequality p=2 s=input.2014q3)

Seeing a lot of this whenever I run "./manage.py ..." commands:

17:52:1397955161 py.warnings:WARNING /home/willkg/mozilla/fjord/vendor/src/django/django/core/cache/backends/memcached.py:146: DeprecationWarning: memcached.CacheClass has been split into memcached.MemcachedCache and memcached.PyLibMCCache. Please update your cache backend setting.
  DeprecationWarning
 :/home/willkg/mozilla/fjord/vendor/src/django/django/core/cache/backends/memcached.py:146
17:52:1397955161 py.warnings:WARNING /home/willkg/mozilla/fjord/vendor/src/django/django/core/management/__init__.py:465: DeprecationWarning: The 'execute_manager' function is deprecated, you likely need to update your 'manage.py'; please see the Django 1.4 release notes (https://docs.djangoproject.com/en/dev/releases/1.4/).
  DeprecationWarning)
 :/home/willkg/mozilla/fjord/vendor/src/django/django/core/management/__init__.py:465
17:52:1397955161 py.warnings:WARNING /home/willkg/mozilla/fjord/vendor/src/django/django/core/management/__init__.py:409: DeprecationWarning: The 'setup_environ' function is deprecated, you likely need to update your 'manage.py'; please see the Django 1.4 release notes (https://docs.djangoproject.com/en/dev/releases/1.4/).
  DeprecationWarning)
 :/home/willkg/mozilla/fjord/vendor/src/django/django/core/management/__init__.py:409


A bunch of that is from funfactory. It's possible funfactory has been updated to fix these things in which case we can upgrade funfactory and be all set. Otherwise we should look at fixing funfactory or ditching it.
This is probably a pre-requisite to updating to Django 1.6.
Sticking this in this quarter. I'm pretty sure Ricky fixed this for SUMO, so I'll talk with him first.
Whiteboard: u=dev c=codequality p= s=input.2014q2
(In reply to Will Kahn-Greene [:willkg] from comment #0)
> 17:52:1397955161 py.warnings:WARNING
> /home/willkg/mozilla/fjord/vendor/src/django/django/core/cache/backends/
> memcached.py:146: DeprecationWarning: memcached.CacheClass has been split
> into memcached.MemcachedCache and memcached.PyLibMCCache. Please update your
> cache backend setting.
>   DeprecationWarning
>  :/home/willkg/mozilla/fjord/vendor/src/django/django/core/cache/backends/

This one is a local settings issue. Check your fjord/settings/local.py?

I just changed my CACHES setting to:

CACHES = {
    'default': {
        'BACKEND': 'django.core.cache.backends.memcached.MemcachedCache', ...


and it's all good now. This is what prod is using already.
(In reply to Will Kahn-Greene [:willkg] from comment #0)
> 17:52:1397955161 py.warnings:WARNING
> /home/willkg/mozilla/fjord/vendor/src/django/django/core/management/__init__.
> py:465: DeprecationWarning: The 'execute_manager' function is deprecated,
> you likely need to update your 'manage.py'; please see the Django 1.4
> release notes (https://docs.djangoproject.com/en/dev/releases/1.4/).
>   DeprecationWarning)
>  :/home/willkg/mozilla/fjord/vendor/src/django/django/core/management/
> __init__.py:465
> 17:52:1397955161 py.warnings:WARNING
> /home/willkg/mozilla/fjord/vendor/src/django/django/core/management/__init__.
> py:409: DeprecationWarning: The 'setup_environ' function is deprecated, you
> likely need to update your 'manage.py'; please see the Django 1.4 release
> notes (https://docs.djangoproject.com/en/dev/releases/1.4/).
>   DeprecationWarning)
>  :/home/willkg/mozilla/fjord/vendor/src/django/django/core/management/
> __init__.py:409
> 
> 
> A bunch of that is from funfactory. It's possible funfactory has been
> updated to fix these things in which case we can upgrade funfactory and be
> all set. Otherwise we should look at fixing funfactory or ditching it.

Yep, these two are from funfactory and I don't see that it has been fixed upstream yet.
Sweet--got rid of the cache-related issue and updated the docs accordingly.

The other two are tied to funfactory so either I need to ditch funfactory or I need to wait for https://github.com/mozilla/funfactory/pull/59 to land.
Depends on: 1016466
Pushing this off to 2014q3.
Whiteboard: u=dev c=codequality p= s=input.2014q2 → u=dev c=codequality p= s=input.2014q3
Grabbing this one to do this week because this causes me to get 72 emails every day. Ew.
Assignee: nobody → willkg
Whiteboard: u=dev c=codequality p= s=input.2014q3 → u=dev c=codequality p=2 s=input.2014q3
FIXED IN https://github.com/mozilla/fjord/commit/fec1319e

I'M SO EXCITED! THIS ISSUE WAS SOOOOO ANNOYING!!! ONLY TOOK 4 1/2 MONTHS!

I'll push it tomorrow.
Status: NEW → ASSIGNED
Couldn't push on Thursday because we were having rabbitmq problems. Pushed it just now.

Yay!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.