Evan Tseng [:evanxd] Reporter
	Description • 10 years ago

We should do JSHint fixes for the files listed at https://github.com/mozilla-b2g/gaia/blob/master/build/jshint/xfail.list#L435-L641. There are 207 files needed to fix.

	Evan Tseng [:evanxd] Reporter
	Comment 1 • 10 years ago

We could list files had good test coverage here, and let contributors to fix them.

	Evan Tseng [:evanxd] Reporter
	Comment 2 • 10 years ago

There are students would like to help this.

	Kevin Grandon :kgrandon
	Comment 3 • 10 years ago

I think that this would be better to do as we land the v2 system refactor in order to streamline review time. Going to go ahead and block bug 1084191 which is tracking our remaining JSHint fixes.

	Sudheesh Singanamalla (:ShellHacker)
	Comment 4 • 9 years ago

I am willing to pick this bug and send the patches since I've worked on most of the jshint bugs so far. Should I fix all of them in one single patch ? or break them down into ?

- apps/system/js/*
- apps/system/test/marionette/*
- apps/system/test/unit/*

	Kevin Grandon :kgrandon
	Comment 5 • 9 years ago

This seems to have sit for a while so if you want to start working through it that would be great! 

Some of the files in the system app are quite large. I would recommend grouping them by folder where possible, or doing chunks of a few files at a time. You could also break them down into smaller groups if you wanted, e.g., apps/system/test/unit/mock_*, and apps/system/test/unit/fxa*

	John Hu [:johnhu][:johu][:醬糊小弟]
	Comment 7 • 9 years ago

The plan for this issue is at:
https://gist.github.com/shamenchens/27192af45c5225946fe8#file-todo-list

We found:
1. jshint error/warning
2. some files had been removed but still in build/jshint/xfail.list

We will try to fix all of them.

	John Hu [:johnhu][:johu][:醬糊小弟]
	Comment 8 • 9 years ago

Phase 1 is all finished. We are waiting for the landing of bug 1094759 to start phase 2.

	John Hu [:johnhu][:johu][:醬糊小弟]
	Comment 9 • 9 years ago

close it \o/