Closed
Bug 990777
Opened 10 years ago
Closed 9 years ago
Input favicon looks bad on retina displays
Categories
(Input :: General, defect)
Input
General
Tracking
(Not tracked)
RESOLVED
FIXED
2015q1
People
(Reporter: cww, Assigned: lgp171188, Mentored)
Details
(Whiteboard: u=user c=general p= s= )
We should totally use a HD favicon.
Comment 1•10 years ago
|
||
Adding the mentor flag--this is a good bug for someone new to work on. Pretty sure SUMO does this already. If so, then we can copy what they do including the files. Their codebase is at https://github.com/mozilla/kitsune/ . This is a mentored bug. If you're interested in working on it, comment here or ping willkg in #input on irc.freenode.net.
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: u=user c=general p= s=input.2014q2 [mentor=willkg]
Comment 2•10 years ago
|
||
Hi willkg, I am interested in this bug . Can you guide me ?
Flags: needinfo?(willkg)
Comment 3•10 years ago
|
||
Biraj: Are the instructions in comment #1 not sufficient? If not, what specific questions do you have?
Flags: needinfo?(willkg)
Comment 4•10 years ago
|
||
Hey willkg: idea is not clear what I have to here ?
Comment 5•10 years ago
|
||
I think if comment #1 doesn't make any sense, then this probably isn't a bug you can work on, yet. I suggest you do one of a few things: 1. ask someone with a bit more time to help you out here 2. look for another bug that interests you 3. look for another project that has bugs that interest you Hope that helps! Sorry about this!
Comment 6•10 years ago
|
||
Thanks willkg . I am looking for another bug that interests me.
Comment 7•10 years ago
|
||
Taking this out of the quarter sprint.
Whiteboard: u=user c=general p= s=input.2014q2 [mentor=willkg] → u=user c=general p= s= [mentor=willkg]
Updated•10 years ago
|
Mentor: willkg
Whiteboard: u=user c=general p= s= [mentor=willkg] → u=user c=general p= s=
Comment 8•9 years ago
|
||
Assigning this to lguruprasad as he's working on it now.
Assignee: nobody → lgp171188
Status: NEW → ASSIGNED
Assignee | ||
Comment 9•9 years ago
|
||
I opened input.mozilla.org on my retina Macbook Pro and could verify this issue. There is pixelation of the favicon since we are using a low resolution image. I also tested sumo and could verify that the issue is not there. So we can go ahead and use the favicons used by sumo. Since willkg suggested that instead of linking directly to the support.cdn.mozilla.net images used by sumo, we could have separate copies for fjord, I am waiting for further inputs from willkg.
Comment 10•9 years ago
|
||
I'm confused. What're you asking me?
Assignee | ||
Comment 11•9 years ago
|
||
Should I link to the images from the same location (support.cdn.mozilla.net) that sumo is using? If not, what should I do?
Comment 12•9 years ago
|
||
Ok--I understand the question now. We don't want to use the SUMO links for those images since we don't control those links and we don't want the images to disappear if/when they move them. We want to copy the image files and put them in fjord just like we host our other images.
Assignee | ||
Comment 13•9 years ago
|
||
Here is the pull request with the changes - https://github.com/mozilla/fjord/pull/459. I tested the favicon on a retina display and could confirm that the pixelation is gone.
Comment 14•9 years ago
|
||
Landed in https://github.com/mozilla/fjord/commit/36eb60b1a5f12d9c2f380a460ef2e33f3f522454 Will push it out next time I do a deployment.
Target Milestone: --- → 2015q1
Comment 15•9 years ago
|
||
Pushed to production just now. Marking as FIXED. Thank you!
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•