Closed Bug 990334 Opened 10 years ago Closed 10 years ago

[Calendar] Newly perma-red marionette test, marionette/today_test.js ("TEST-UNEXPECTED-FAIL | today should show in header, highlighted day")

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S5 (11apr)

People

(Reporter: kgrandon, Assigned: evanxd)

Details

(Keywords: intermittent-failure, Whiteboard: [p=2])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
mmedeiros
: review+
Details | Review
This just started failing on all pull requests this morning, possibly date specific?

1) today should show in header, highlighted day:

expected '' to equal 1

2) today should be show in header, highlighted day after tap today:

expected '' to equal 1
Can you guys look at this to determine if this is a regression or a test issue? Thanks!
Flags: needinfo?(mmedeiros)
Flags: needinfo?(gaye)
From IRC:

> glandium: Tomcat|sheriffduty: Being that this is inside of a calendar app, it's possible that 3/31 -> 4/1 may have caused some race condition.
> kgrandon: that makes sense, since the test suite started at 23:48 and finished at 00:26
Assignee: nobody → evanxd
Status: NEW → ASSIGNED
Attached file Pull request
Hi Kevin,

I think the structure of dom tree might be changed.
If we change the css selector of current day item, the test could work.
Attachment #8399927 - Flags: review?(kgrandon)
Sorry, I think it is a test issue.

The css selector at https://github.com/mozilla-b2g/gaia/pull/17846/files#diff-6e35d518cd989ea57e1b7dc6c5860f25L16 is not correct for current day item when the structure of the dom tree is like below:
```
<section id="month-view" class="active">
  <section class="month"></section>
  <section class="month active"></section>
  <section class="month"></section>
</section>
```

So we should change the css selector to fix the issue.
Adding ability for TBPL for auto-suggest this.
Summary: [Calendar] Newly perma-red marionette test, marionette/today_test.js → [Calendar] Newly perma-red marionette test, marionette/today_test.js ("TEST-UNEXPECTED-FAIL | today should show in header, highlighted day")
Target Milestone: --- → 1.4 S5 (11apr)
Whiteboard: [p=2]
Comment on attachment 8399927 [details] [review]
Pull request

Hi Miller,

Could you help me to review the patch?
Thanks.
Attachment #8399927 - Flags: review?(kgrandon) → review?(mmedeiros)
Comment on attachment 8399927 [details] [review]
Pull request

to be honest I don't know what caused the bug (why it was not happening before), but the patch does fix the problem and is a simple change (only affects the test files). So I'm r+ it.
Attachment #8399927 - Flags: review?(mmedeiros) → review+
Flags: needinfo?(mmedeiros)
Flags: needinfo?(gaye)
Target Milestone: 1.5 S1 (9may) → 1.4 S5 (11apr)
Hi Miller,

Thanks for the review.

I'm wondering that why are so many comments posted by TBPL Robot here.
Does anyone know why?
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
(In reply to Miller Medeiros [:millermedeiros] from comment #10)
> Comment on attachment 8399927 [details] [review]
> Pull request
> 
> to be honest I don't know what caused the bug (why it was not happening
> before), but the patch does fix the problem and is a simple change (only
> affects the test files). So I'm r+ it.

Hi Miller,
We could see the root cause at Comment 5.
Hi Evan, the weird thing is that this test was probably passing before the PR was merged and we did not make that many changes to calendar after that. I thought it was my fault but even after reverting my changes it was still broken.. but no big deal, now the selector reflects the proper DOM structure. Thanks for the good work!
(In reply to Evan Tseng [:evanxd][:愛聞插低] from comment #26)
> Hi Miller,
> 
> Thanks for the review.
> 
> I'm wondering that why are so many comments posted by TBPL Robot here.
> Does anyone know why?

its because if they show up on tbpl we get bug recommendations like this one and star this failures as sheriffs, thats why :)
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: