Kevin Grandon :kgrandon Assignee
	Description • 10 years ago

Currently several errors appear when running this test in a sandbox. We need to fix this to enable it to run on TBPL.

A typical error: 

1) [calendar] Templates.Alarm #description minutes:
     TypeError: Calendar.App.dateFormat is undefined
      at description (http://calendar.gaiamobile.org:8080/js/templates/alarm.js:59)
      at render (http://calendar.gaiamobile.org:8080/js/template.js:85)
      at renderDescription (http://calendar.gaiamobile.org:8080/test/unit/templates/alarm_test.js:19)
      at (anonymous) (http://calendar.gaiamobile.org:8080/test/unit/templates/alarm_test.js:26)
      at wrapper (http://calendar.gaiamobile.org:8080/common/test/mocha_generators.js:62)
      at run (http://calendar.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
      at runTest (http://calendar.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081)
      at (anonymous) (http://calendar.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127)
      at next (http://calendar.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007)
      at (anonymous) (http://calendar.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016)
      at next (http://calendar.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964)
      at (anonymous) (http://calendar.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984)
      at (anonymous) (http://calendar.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)

	Kevin Grandon :kgrandon Assignee
	Comment 2 • 10 years ago

On try: https://tbpl.mozilla.org/?tree=Try&rev=23755f865a06

	Kevin Grandon :kgrandon Assignee
	Comment 3 • 10 years ago

Comment on attachment 8398036 [details] [review]
Github pull request

Miller or Gareth - anyone got time for a review? Thanks!

	Kevin Grandon :kgrandon Assignee
	Comment 4 • 10 years ago

Comment on attachment 8398036 [details] [review]
Github pull request

Or Evan - if you have a minute could you throw a review stamp on this? Thanks!

	Evan Tseng [:evanxd]
	Comment 5 • 10 years ago

Hi Kevin,

For the undefined issue of Calendar.App.dateFormat, I think we could just do `Calendar.App.dateFormat = navigator.mozL10n.DateTimeFormat();` to fix it.

How do you think?

	Evan Tseng [:evanxd]
	Comment 6 • 10 years ago

See the GitHub commit at https://github.com/mozilla-b2g/gaia/pull/17724/files#r11162373.

	Evan Tseng [:evanxd]
	Comment 7 • 10 years ago

Sorry, the correct link is https://github.com/mozilla-b2g/gaia/pull/17724/files#r11162373.

	Evan Tseng [:evanxd]
	Comment 8 • 10 years ago

Comment on attachment 8398036 [details] [review]
Github pull request

Hi Kevin,

r+,
thanks for the good work.

	Kevin Grandon :kgrandon Assignee
	Comment 9 • 10 years ago

Thanks for the review!

https://github.com/mozilla-b2g/gaia/commit/39b307f67e8945f6ec458e72c8734c907413b14e

	Julien Wajsberg [:julienw]
	Comment 10 • 10 years ago

v1.4: 71aa8a3697e8daacdaee3d447a38ee10f13d5b54