Gareth Aye [:gaye] (back from PTO) Reporter
	Description • 10 years ago

      No description provided.

	Miller Medeiros [:millermedeiros]
	Comment 1 • 10 years ago

I'm making some changes to week_view test to catch a regression (Bug 989785), so this will need to wait. Sorry for that.

	Evan Tseng [:evanxd] Assignee
	Comment 2 • 10 years ago

Got you.
Thanks.

	Evan Tseng [:evanxd] Assignee
	Comment 4 • 10 years ago

Comment on attachment 8400554 [details] [review]
Pull request

Hi Miller,

Could you help me to review the patch?
Thanks.

	Evan Tseng [:evanxd] Assignee
	Comment 5 • 10 years ago

Comment on attachment 8400554 [details] [review]
Pull request

Sorry, we should make sure the test case could be passed for 30 times continually on Travis first, then we could do the review process.

See the 30 times result at https://travis-ci.org/mozilla-b2g/gaia/builds/22105389.

	Evan Tseng [:evanxd] Assignee
	Comment 6 • 10 years ago

Comment on attachment 8400554 [details] [review]
Pull request

Hi Miller,

Could you help me to review the patch?
The test is already passed for 30 times continually on Travis,
see it in https://travis-ci.org/mozilla-b2g/gaia/builds/22105389.

Thanks.

	Evan Tseng [:evanxd] Assignee
	Comment 7 • 10 years ago

Hi Miller,

I already updated the patch
Please help me to review it.

And the test is also passed for 30 times on Travis,
and see it at https://travis-ci.org/mozilla-b2g/gaia/builds/22174174.

Thanks.

	Miller Medeiros [:millermedeiros]
	Comment 8 • 10 years ago

Comment on attachment 8400554 [details] [review]
Pull request

looking good! thanks!

	Evan Tseng [:evanxd] Assignee
	Comment 9 • 10 years ago

Hi Miller,

Thanks for the review.

	Evan Tseng [:evanxd] Assignee
	Comment 10 • 10 years ago

master: https://github.com/mozilla-b2g/gaia/commit/c13fa17359652a97253aa1004d74758921af57a7