Gareth Aye [:gaye] (back from PTO) Reporter
	Description • 10 years ago

      No description provided.

	Evan Tseng [:evanxd] Assignee
	Comment 1 • 10 years ago

The WIP patch.

	Miller Medeiros [:millermedeiros]
	Comment 2 • 10 years ago

Comment on attachment 8399374 [details] [review]
Pull request

talked with gaye on IRC, adding it to my review queue since he is swamped with other work.. - will start reviewing it tomorrow.

	Evan Tseng [:evanxd] Assignee
	Comment 3 • 10 years ago

Hi Miller,

Thanks for your help.

And sorry, the patch could not run on Travis but work well on local, see it at https://travis-ci.org/mozilla-b2g/gaia/jobs/22007323.
I'm checking on it.

	Evan Tseng [:evanxd] Assignee
	Comment 4 • 10 years ago

Hi Miller,

I updated the patch for your comments.
Please help me to review it.

30 times pass on Travis: https://travis-ci.org/mozilla-b2g/gaia/builds/22332302

Thanks.

	Miller Medeiros [:millermedeiros]
	Comment 5 • 10 years ago

I plan to reuse the logic to navigate to settings view on Bug 969472, so marking this as a blocker. - I already implemented it but will need to migrate my tests to new structure after this lands..

	Miller Medeiros [:millermedeiros]
	Comment 6 • 10 years ago

Comment on attachment 8399374 [details] [review]
Pull request

nice work! only comment I have now is that I think the "test_apps/music2/js/metadata_scripts.js" changes was committed by mistake together with the patch. I think we should remove that. (patch should only contain calendar changes). thanks!

	Evan Tseng [:evanxd] Assignee
	Comment 7 • 10 years ago

Hi Miller,

Sorry, it is a mistake. I already fixed that.
Thanks for the review.

	Evan Tseng [:evanxd] Assignee
	Comment 8 • 10 years ago

master: https://github.com/mozilla-b2g/gaia/commit/7efa9ab3234207fd2fd818a5c1411f390619dbfc

	Gareth Aye [:gaye] (back from PTO) Reporter
	Comment 9 • 10 years ago

Reverted since this is breaking intermittently... see

12:29 PM <gaye> https://travis-ci.org/mozilla-b2g/gaia/jobs/22608207
12:29 PM <gaye> https://travis-ci.org/mozilla-b2g/gaia/jobs/22602942

Miller has ideas about what's broken so ni'ing both of y'all.

	Miller Medeiros [:millermedeiros]
	Comment 10 • 10 years ago

the backout commit: https://github.com/mozilla-b2g/gaia/commit/43ca8f7fd195fe227c2d46ba2abf51b03483636c

the problem seems to be related to the `waitForTransitionEnd` code, maybe we should simply check if the `#time-views` is at the position that we expect it to be (check the `translateX`).

the `waitForTransitionEnd` is also breaking the `app.launch` in some cases, to be honest I don't think this code is needed there since the tests was working before adding that.

	Evan Tseng [:evanxd] Assignee
	Comment 11 • 10 years ago

Hi Miller,

Good idea.
I already updated the patch for that, see it at https://github.com/evanxd/gaia/blob/a2de0df709370b9670bf03f865b8366c99920843/apps/calendar/test/marionette/lib/calendar.js#L78-L89.

I will set review again once the 102 times travis job(https://travis-ci.org/mozilla-b2g/gaia/builds/22677116) is passed.

Thanks.

	Evan Tseng [:evanxd] Assignee
	Comment 13 • 10 years ago

Comment on attachment 8404654 [details] [review]
Pull request

Hi Miller,

The patch is passed on Travis for 102 times, see it at https://travis-ci.org/mozilla-b2g/gaia/builds/22684917.

Please help to review the patch. The change is https://github.com/evanxd/gaia/blob/bug-987351/apps/calendar/test/marionette/lib/calendar.js#L78-L89.

Thanks.

	Miller Medeiros [:millermedeiros]
	Comment 14 • 10 years ago

Comment on attachment 8404654 [details] [review]
Pull request

just a small nit on GH. hopefully no more intermittent failures. please make sure you run tests multiple times before merging! thanks!

	Evan Tseng [:evanxd] Assignee
	Comment 15 • 10 years ago

Hi Miller,

Thanks for the review.
And the patch is also could be passed for 102 time on Travis, see it at https://travis-ci.org/evanxd/gaia/builds/22828154.

	Evan Tseng [:evanxd] Assignee
	Comment 16 • 10 years ago

master: https://github.com/mozilla-b2g/gaia/commit/c91505164430b7edc9d583c52f21fa1f06d13101