Gareth Aye [:gaye] (back from PTO) Reporter
	Description • 10 years ago

Evan can you fix this? The order of the environment variables (including RUN_CALDAV_SERVER) should not matter.

https://github.com/mozilla-b2g/gaia/blob/master/bin/gaia-marionette#L7

	Evan Tseng [:evanxd] Assignee
	Comment 1 • 10 years ago

Hi Gareth,

Sorry, I didn't notice this bug.
Sure, let me fix that.
Thanks.

	Evan Tseng [:evanxd] Assignee
	Comment 2 • 10 years ago

Hi Gareth,

How about this patch https://github.com/mozilla-b2g/gaia/pull/16435?
Could we do install radicale server if INSTALL_CALDAV_SERVER flag equal 1 in the gaia-marionette file?
Or we just would like to do some documentation to notice users to install the radicale before they run the calednar related tests?

How do you think how do we handle the radicale installation?

Thanks.

	Evan Tseng [:evanxd] Assignee
	Comment 3 • 10 years ago

And the Bug 973876 is fixing the sudo things.

	Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)
	Comment 4 • 10 years ago

discussed with Evan, things we can do here:

1. remove installing radicale part from bin/marionette
2. add a makefile rule for installing radicale
3. disable caldav-related integration tests if radicale isn't available (but give a warning message for installing radicale by make.)

	Evan Tseng [:evanxd] Assignee
	Comment 5 • 10 years ago

Hi Gareth,

How do you think about Comment 4?

I would like do this to fix the sudo issue.
The issue stays too long.

Thanks.

Evan

	Gareth Aye [:gaye] (back from PTO) Reporter
	Comment 6 • 10 years ago

That sounds good to me!

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 7 • 10 years ago

Evan, please leave an update here since you listed this bug on the weekly report.

	Evan Tseng [:evanxd] Assignee
	Comment 8 • 10 years ago

Hi Gareth,

Could you give me the feedback about the WIP patch?
We skip the CalDAV related tests with the https://github.com/mozilla-b2g/gaia/pull/17515/files#diff-93c8db4b2f7d60eb0c3cc4893191e727R29 way.
Thanks.

	Evan Tseng [:evanxd] Assignee
	Comment 9 • 10 years ago

Hi Tim,

I had a WIP patch at https://github.com/mozilla-b2g/gaia/pull/17515.

Thanks.

	Evan Tseng [:evanxd] Assignee
	Comment 10 • 10 years ago

Hi all,

After discussed with gaye and yuren, we would like to have SKIP_TESTS variable. And  if we detect the radicale CalDav server is NOT installed, then we could do SKIP_TESTS="<caldav tests>" params with doing gaia-marionetted.

And we add make task for installing the Radicale CalDAV server. The CalDAV server helper in https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/test/marionette/lib/radicale.js#L65-L83 will active it at run time.

	Evan Tseng [:evanxd] Assignee
	Comment 11 • 10 years ago

(In reply to Yuren [:yurenju][:小朱] from comment #4)
> discussed with Evan, things we can do here:
> 
> 1. remove installing radicale part from bin/marionette
> 2. add a makefile rule for installing radicale
> 3. disable caldav-related integration tests if radicale isn't available (but
> give a warning message for installing radicale by make.)

The https://github.com/evanxd/gaia/commit/5c36049631db009653e47418964b7acc827647f0 commit is WIP patch for the above things.

	Evan Tseng [:evanxd] Assignee
	Comment 12 • 10 years ago

Comment on attachment 8395593 [details] [review]
Pull request

Hi Gareth,

I updated the patch for the "SKIP_FILES" solution.
Please help me to take a look and give me feedback for it.
https://github.com/mozilla-b2g/gaia/pull/17515/files#diff-55743de39889bf62680340b58fffbd1eR7

Thanks.

	Evan Tseng [:evanxd] Assignee
	Comment 13 • 10 years ago

Comment on attachment 8395593 [details] [review]
Pull request

Hi Yuren,

Please help me to review the patch.
Thanks.

	Gareth Aye [:gaye] (back from PTO) Reporter
	Comment 14 • 10 years ago

Comment on attachment 8395593 [details] [review]
Pull request

Thanks Evan. This is much better. Deferring review to yuren since I am not great at bash...

	Evan Tseng [:evanxd] Assignee
	Comment 15 • 10 years ago

Hi Gareth,

Thanks for the feedback.

	Evan Tseng [:evanxd] Assignee
	Comment 16 • 10 years ago

Comment on attachment 8395593 [details] [review]
Pull request

Yuren have no time to review the patch now.
Thanks for George's help.

Hi George,

Please help me to review the patch.
Thanks. :)

	(Inactive after June) George Duan [:gduan] [:喬智]
	Comment 17 • 10 years ago

Comment on attachment 8395593 [details] [review]
Pull request

r=gduan
This patch is fine. Please remember to open two follow-up bugs as below.
1. We need the same change for gaia-marionette-parallel. 
2. follow-up of https://github.com/mozilla-b2g/gaia/pull/17515#discussion_r11009589

	Evan Tseng [:evanxd] Assignee
	Comment 18 • 10 years ago

Hi George,

Thanks for the review.

	Evan Tseng [:evanxd] Assignee
	Comment 19 • 10 years ago

master: https://github.com/mozilla-b2g/gaia/commit/12bc17ae4988c9532749e95f39968a894dd757a9