Closed Bug 977450 Opened 10 years ago Closed 10 years ago

[WebApp][Manifest] Use "chrome": { "navigation": false } in app manifest makes a packaged app's chrome visible

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(blocking-b2g:1.4+, b2g-v1.4 fixed)

Status:
RESOLVED FIXED
Milestone:
1.4 S3 (14mar)
Project Flags:
blocking-b2g 1.4+
Tracking Flags:
Tracking Status
b2g-v1.4 --- fixed

People

(Reporter: Omega, Assigned: alive)

Details

(Keywords: regression, Whiteboard: [systemsfe])

Attachments

(2 files)

ChromeTest.zip
17.47 KB, application/zip
Details
Patch for master
46 bytes, text/x-github-pull-request
etienne
: review+
Details | Review 
[Steps To Reproduce]
1. Use "chrome": { "navigation": false } in app manifest
2. Package the app
3. Install the app
4. Launch the app
 
[Actual Result]
The chrome is visible

[Expected Result]
The chrome is invisible


Device: Hamachi
OS Version: 1.4.0.0-prerelease
Platform Version: 30.0a1
Build Identifier: 20140226040201
Well that's definitely not right. Can you include a test case here? I want to understand if this is known or a regression.
Component: Gaia::System::Browser Chrome → Gaia::System
Attached file ChromeTest.zip — 
Installing this test app on 1.3 or earlier version, there is no chrome.
But installing on 1.4, the chrome appears unexpectedly.

Device: Hamachi
OS Version: 1.4.0.0-prerelease
Platform Version: 30.0a1
Build Identifier: 20140226040201
blocking-b2g: --- → 1.4?
Keywords: regression, regressionwindow-wanted
Ben, Alive, any idea whats going on here?
Flags: needinfo?(bfrancis)
Flags: needinfo?(alive)
Whiteboard: [systemsfe]
Taken first.
Assignee: nobody → alive
Flags: needinfo?(alive)
blocking-b2g: 1.4? → 1.4+
Attached file Patch for master — 
Do not instantiate AppChrome if navigation is false.
I feel I should check 'chrome.title' as well but we don't have official naming for that so let it be.
Attachment #8385082 - Flags: review?(etienne)
Attachment #8385082 - Flags: review?(etienne) → review+
master
https://github.com/mozilla-b2g/gaia/commit/4d624378b96e57a77557af4f0808211a97ec3e39
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Flags: needinfo?(bfrancis)
status-b2g-v1.4: --- → fixed
Target Milestone: --- → 1.4 S3 (14mar)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: