Closed
Bug 973876
Opened 10 years ago
Closed 10 years ago
make test-integration shouldn't ask for admin password
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Firefox OS Graveyard
Gaia::Calendar
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 978933
People
(Reporter: rik, Assigned: evanxd)
References
Details
Attachments
(1 file)
This is really bad practice and we should have another way to setup the test environment for this one. In the mean time, I'm running those tests with RUN_CALDAV_SERVER=0.
Comment 1•10 years ago
|
||
What the heck?
Reporter | ||
Comment 2•10 years ago
|
||
Slightly related, if we need manual steps to install the right python environment, I think we should let people easily run the tests that don't need a python environment.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → evanxd
Assignee | ||
Comment 3•10 years ago
|
||
Hi Anthony, Sorry. I will fix this. We will do `make test integration` without the password.
Assignee | ||
Comment 4•10 years ago
|
||
Hi George, Please help me to review the patch. Currently, there is no "radicale installation" error. It might be a pip server issue. Thanks. :)
Attachment #8378095 -
Flags: review?(gduan)
Assignee | ||
Updated•10 years ago
|
Attachment #8378095 -
Flags: review?(gduan)
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8378095 [details] [review] Pull request Hi Gareth, Currently, gaia tree is closed. And I have a simple solution without reverting the CalDav patch. We could just remove the `sudo`, and it works fine. Thanks.
Attachment #8378095 -
Flags: feedback?(gaye)
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8378095 [details] [review] Pull request Hi Rik, How do you think? We could just remove the `sudo`. It let test run well without the password. Thanks.
Attachment #8378095 -
Flags: feedback?(anthony)
Comment 7•10 years ago
|
||
(In reply to Evan Tseng [:evanxd][:愛聞插低] from comment #5) > Comment on attachment 8378095 [details] [review] > Pull request > > Hi Gareth, > > Currently, gaia tree is closed. > And I have a simple solution without reverting the CalDav patch. > We could just remove the `sudo`, and it works fine. > > Thanks. That won't work for people who have pip configured to install to a privileged location. Unless it's being installed into the virtualenv dir?
Comment 8•10 years ago
|
||
we shouldn't install anything in user's machine in build process except we only install them in gaia directory like npm or virtualenv. I suggest throwing an error if user don't have virtualenv and remove virtualenv installtion from gaia-marionette.
Assignee | ||
Comment 9•10 years ago
|
||
I would like to take Yuren's suggestion. How do you think, Gareth?
Reporter | ||
Comment 10•10 years ago
|
||
I agree with Yuren in comment 8.
Comment 11•10 years ago
|
||
+1
Reporter | ||
Updated•10 years ago
|
Attachment #8378095 -
Flags: feedback?(anthony) → feedback-
Assignee | ||
Comment 12•10 years ago
|
||
Sure, let's do Comment 8. Thanks.
Assignee | ||
Updated•10 years ago
|
Attachment #8378095 -
Flags: feedback?(gaye)
Assignee | ||
Comment 13•10 years ago
|
||
Comment on attachment 8378095 [details] [review] Pull request Hi Yuren, Please help me review the patch. And we could skip the CalDAV installation with INSTALL_CALDAV_SERVER=0 in terminal. Thanks.
Attachment #8378095 -
Flags: review?(yurenju.mozilla)
Assignee | ||
Comment 14•10 years ago
|
||
Ah, we need to install virtaulenv on Travis, or we get this error https://travis-ci.org/mozilla-b2g/gaia/jobs/19319491.
Comment 15•10 years ago
|
||
Comment on attachment 8378095 [details] [review] Pull request r=yurenju if nits are addressed.
Attachment #8378095 -
Flags: review?(yurenju.mozilla) → review+
Assignee | ||
Comment 16•10 years ago
|
||
Hi Yuren, Thank for the review.
Assignee | ||
Comment 17•10 years ago
|
||
Hi Yuren, We need to use sudo to install Radicale on Travis. So there is no sudo things on local.
Comment 18•10 years ago
|
||
it's fine to me if only use |sudo| on travis-ci, so let's land it!
Reporter | ||
Comment 19•10 years ago
|
||
How do the tests behave if I don't install the server? I think tests that require the server should be skipped and the runner should output something like: "Warning: Caldav related tests have not been ran. If you want to run them, follow these instructions: <link to instructions>"
Assignee | ||
Comment 20•10 years ago
|
||
Hi Rik, Current, the test will be just failed, because it could not connect with the server. You have the good point, we should output something like "Warning: Caldav related tests have not been ran." when test could not find the server. We already have follow up bug for that, see Bug 975662.
Assignee | ||
Comment 21•10 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/447eb65ee5a7428e3959ac3b1c0a3fbbfc125d43
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 22•10 years ago
|
||
This left gaia-integration-on-tbpl completely unable to run, https://tbpl.mozilla.org/php/getParsedLog.php?id=35060047&tree=B2g-Inbound
Reporter | ||
Comment 23•10 years ago
|
||
I reverted this based on comment 22. a7f74301b60c45449e19cf012386a4481040e2a8
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 24•10 years ago
|
||
The error message: 11:04:17 INFO - Please install virtualenv before you run marionette test. 11:04:17 INFO - make: *** [test-integration] Error 1 It is because that we didn't have virtualenv on TBPL. So we could just install virtualenv to fix the problem.
Assignee | ||
Comment 25•10 years ago
|
||
Hi Phil, I would like to install virtualenv on TBPL to fix the issue. But I didn't have much knowledge about TBPL. Could you me some tips to install stuffs on TBTL? Thanks.
Flags: needinfo?(philringnalda)
Comment 26•10 years ago
|
||
Step one is to realize that you don't mean "on TBPL" - tbpl is just a viewer, a thing that shows you the results of things run on releng's machines. Even though we do casually call both the viewer and releng's automation that, once you switch to needing to talk to releng, you'll just confuse them by saying it, making them think you want to install something on the server which runs the tbpl webtool. So what you do is file a bug (marked as blocking this bug) in the Release Engineering product, Platform Support component, telling them you need virtualenv available for a test suite, and which test suite, gaia-integration, and what platforms it runs on, linux32 and linux64, and making sure to use the word "test" several times because there are test slaves and build slaves and you don't want them thinking you want something available on the build slaves.
Flags: needinfo?(philringnalda)
Assignee | ||
Comment 27•10 years ago
|
||
Hi Phil, I already done that. Really thanks for your help.
No longer depends on: 976465
Assignee | ||
Updated•10 years ago
|
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•