Kevin Brosnan [Ex-Mozilla] Reporter
	Description • 10 years ago

This bug was filed from the Socorro interface and is 
report bp-6f045fd1-4533-43b0-b3d9-523a52140208.
=============================================================

Crash comments and URLs suggest Flash is involved. Only happens on Android 4.3 on devices using Qualcomm Adreno (TM) 225 and Qualcomm Adreno (TM) 320. AT&T, Verizon and Sprint versions of the Galaxy S3 are at the top of the list.

	Aaron Train [:aaronmt]
	Comment 1 • 10 years ago

Does MV have any of those S3's?

	Aaron Train [:aaronmt]
	Comment 2 • 10 years ago

My Sony Xperia Tablet Z (SGP311) is showing up on the device listing and I can reproduce.

Steps: play any MP4 on my test-page

http://people.mozilla.org/~atrain/mobile/tests/media.html

I'll try and get a stack from a debug build.

	Aaron Train [:aaronmt]
	Comment 3 • 10 years ago

Here's an exact video where on play it crashes: http://people.mozilla.org/~atrain/mobile/tests/big-buck-high.mp4

	Aaron Train [:aaronmt]
	Comment 4 • 10 years ago

As far as I can go without proper symbols

warning: Could not load shared library symbols for libOmxCore.so.
Do you need "set solib-search-path" or "set sysroot"?
warning: Could not load shared library symbols for libstagefright_soft_aacdec.so.
Do you need "set solib-search-path" or "set sysroot"?
warning: Could not load shared library symbols for libmm-color-convertor.so.
Do you need "set solib-search-path" or "set sysroot"?
warning: Could not load shared library symbols for libI420colorconvert.so.
Do you need "set solib-search-path" or "set sysroot"?

Program received signal SIGBUS, Bus error.
[Switching to Thread 17352]
0x854fb66e in ?? ()
(gdb) bt
#0  0x854fb66e in ?? ()
#1  0x854fb850 in ?? ()
#2  0x854fb850 in ?? ()
Backtrace stopped: previous frame identical to this frame (corrupt stack?)

	Aaron Train [:aaronmt]
	Comment 5 • 10 years ago

Last good revision: 0d11fce4f845 (2013-12-16)
First bad revision: b1e5ade62913 (2013-12-17)
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0d11fce4f845&tochange=b1e5ade62913

65adb5a76773	Edwin Flores — Bug 866080 - Use Android I420ColorConverter in OMX plugin r=sotaro,doublec

	Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin] Assignee
	Comment 6 • 10 years ago

Looking at this now.

	Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin] Assignee
	Comment 7 • 10 years ago

Android 4.2 introduced some relatively major changes in the way that Android
negotiates its output colour format. This was fixed on 4.4 KitKat in bug 953394.
This patch just lets Android versions 4.2 and 4.3 use the same fix.

	Kevin Brosnan [Ex-Mozilla] Reporter
	Comment 8 • 10 years ago

If this is reviewed can we land this on trunk soon? Would like to get this in to beta which has about 14 more days before the tree closes for release.

	Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin] Assignee
	Comment 9 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/a15a762f7eef

	Carsten Book [:Tomcat]
	Comment 10 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/a15a762f7eef

	Kevin Brosnan [Ex-Mozilla] Reporter
	Comment 11 • 10 years ago

Arron would you verify?

	Lukas Blakk [:lsblakk] use ?needinfo
	Comment 12 • 10 years ago

Can we get uplift nomination here so this can be in the next Beta?

	Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin] Assignee
	Comment 13 • 10 years ago

Comment on attachment 8378055 [details] [diff] [review]
Set preferred video colour format for OMX on Android 4.2 and 4.3

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 953394.
User impact if declined: Android 4.2 and 4.3 devices with Qualcomm SoCs crashing.
Testing completed (on m-c, etc.): Has been on m-c for about a week.
Risk to taking this patch (and alternatives if risky): Minimal.
String or IDL/UUID changes made by this patch: None.

	Sylvestre Ledru [:Sylvestre]
	Comment 14 • 10 years ago

Comment on attachment 8378055 [details] [diff] [review]
Set preferred video colour format for OMX on Android 4.2 and 4.3

Approving also for beta (see comment #12 from Lukas)

	Ryan VanderMeulen [:RyanVM]
	Comment 15 • 10 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/bf3f7ce9b7bf
https://hg.mozilla.org/releases/mozilla-beta/rev/0218f8a426fd

	Ryan VanderMeulen [:RyanVM]
	Comment 16 • 10 years ago

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/0218f8a426fd