Closed
Bug 945601
Opened 11 years ago
Closed 11 years ago
[LockScreen] The acceleration mode of LockScreen should be more smooth
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(b2g-v1.3 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
b2g-v1.3 | --- | fixed |
People
(Reporter: gweng, Assigned: gweng)
Details
Attachments
(1 file)
Currently it use addition to accelerate the sliding while dragging. It should be more smooth to use a curve instead of.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gweng
Assignee | ||
Comment 1•11 years ago
|
||
I've found the y = x^1.2 may be a good curve.
Assignee | ||
Comment 2•11 years ago
|
||
May need UX's opinion. I send the patch to show the code differences first.
Attachment #8347855 -
Flags: review?(timdream)
Assignee | ||
Comment 3•11 years ago
|
||
Finally we decide to use x^1.02.
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 8347855 [details] [review] Patch I found a possible way to adjust the accelerating factor for the left side, I would make some modifications and set the review again.
Attachment #8347855 -
Flags: review?(timdream)
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 8347855 [details] [review] Patch Set the review flag again.
Attachment #8347855 -
Flags: review?(timdream)
Comment 6•11 years ago
|
||
Comment on attachment 8347855 [details] [review] Patch Glad to see there are more red than green in the patch!
Attachment #8347855 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 7•11 years ago
|
||
Travis still stuck at marionette.js, but it seems unrelated according to previous result. master: https://github.com/mozilla-b2g/gaia/commit/0da6efc6bcd4a40b6e4378b15f9aacfb6f5921a2
Assignee | ||
Comment 8•11 years ago
|
||
I've forgot to tag this as resolved...
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•10 years ago
|
||
This bug should be checked in to let related bug (like Bug 935148) not conflicts with this. And Tim grant this as approval-gaia-v1.3+ offline (I just asked him, and he approved that).
Assignee | ||
Comment 10•10 years ago
|
||
v1.3: https://github.com/mozilla-b2g/gaia/commit/e57e0be9e3b7a880053e5e45e9a0ff27f75478f5
status-b2g-v1.3:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•