Closed Bug 936371 Opened 11 years ago Closed 11 years ago

[marionette-plugin] APIs to setup video, image, music resources for testing.

Categories

(Testing Graveyard :: JSMarionette, defect)

Product:
Testing Graveyard
Component:
JSMarionette
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: evanxd, Assigned: evanxd)

Details

Attachments

(1 file, 3 obsolete files)

Pull request
411 bytes, text/html
jlal
: review+
Details 
Hi all,

We should have a marionette plugin to setup video, image, music resources for testing job.
It is very useful to do testing in Video, Gallery, Music... Apps.
Assignee: nobody → evanxd
Suggest to support the following thing:

1. put a single file
2. add a bunch of file
3. delete a single file
4. delete a bunch of file

There is one thing need to be confirmed if device storage still watches the change of file system. We use it to dynamic change our list during the execution. If it works, we can create a case that when a user watch a video and some background app creates a video or deletes a video.
Hi all,

How do you guys think?
This plugin could be useful for Video, Gallery, Music App.
Flags: needinfo?(jlal)
Flags: needinfo?(gaye)
Flags: needinfo?(mike)
Very useful! Are you familiar with the work our intern (tom) did in this realm for b2g-desktop?

https://github.com/mozilla-b2g/gaia/pull/12169/files#diff-354c7fb3ca672cdd460d8614748fa7f0R7

This can be adapted very easily for any device storage case (and hopefully into a sync only plugin) but we need to keep in mind the process will be different for the device (adb) case.
Flags: needinfo?(jlal)
Sounds good to me!
Flags: needinfo?(mike)
Attached file Pull request (obsolete) — 
Hi James,

Please help review the patch.
One I have permission of https://github.com/mozilla-b2g/marionette-file-manager,
I will send PR to it.
Attachment #8333656 - Flags: review?(jlal)
Attached file Patch v1 (obsolete) — 
Hi James,

Please help review the patch.
One I have permission of https://github.com/mozilla-b2g/marionette-file-manager,
I will send PR to it.
Attachment #8333656 - Attachment is obsolete: true
Attachment #8333656 - Flags: review?(jlal)
Attachment #8333657 - Flags: review?(jlal)
Attachment #8333657 - Attachment mime type: text/plain → text/html
Comment on attachment 8333657 [details]
Patch v1

><!DOCTYPE html>
><meta charset="utf-8">
><meta http-equiv="refresh" content="5;https://github.com/evanxd/marionette-file-manager/commit/f855e36e8777db69c55980e293f155124a693783">
><title>Bugzilla Code Review</title>
><p>You can review this patch at <a href="https://github.com/evanxd/marionette-file-manager/commit/f855e36e8777db69c55980e293f155124a693783">https://github.com/evanxd/marionette-file-manager/commit/f855e36e8777db69c55980e293f155124a693783</a>, or wait 5 seconds to be redirected there automatically.</p>
Comment on attachment 8333657 [details]
Patch v1

><!DOCTYPE html>
><meta charset="utf-8">
><meta http-equiv="refresh" content="5;https://github.com/evanxd/marionette-file-manager/commit/ca3adb5ecdce592f0a5caa81aa2e9d56e11af481">
><title>Bugzilla Code Review</title>
><p>You can review this patch at <a href="https://github.com/evanxd/marionette-file-manager/commit/ca3adb5ecdce592f0a5caa81aa2e9d56e11af481">https://github.com/evanxd/marionette-file-manager/commit/ca3adb5ecdce592f0a5caa81aa2e9d56e11af481</a>, or wait 5 seconds to be redirected there automatically.</p>
Attachment #8333657 - Flags: review?(jlal)
Attached file Pull request (obsolete) — 
Hi James,

Please help review the patch.
One I have permission of https://github.com/mozilla-b2g/marionette-file-manager,
I will send PR to it.
Thanks.
Attachment #8333657 - Attachment is obsolete: true
Attachment #8333895 - Flags: review?(jlal)
Attachment #8333895 - Attachment mime type: text/plain → text/html
Comment on attachment 8333895 [details]
Pull request

<!DOCTYPE html>
<meta charset="utf-8">
<meta http-equiv="refresh" content="5;https://github.com/mozilla-b2g/marionette-file-manager/pull/1">
<title>Bugzilla Code Review</title>
<p>You can review this patch at <a href="https://github.com/mozilla-b2g/marionette-file-manager/pull/1">https://github.com/mozilla-b2g/marionette-file-manager/pull/1</a>, or wait 5 seconds to be redirected there automatically.</p>
Attachment #8333895 - Attachment description: Patch v2 → Pull request
Attachment #8333895 - Flags: review?(jlal)
Attached file Pull request — 
Hi James,

Already sent PR to marionette-file-manager in mozilla-b2g.
Please help me review the patch.

Thanks.
Attachment #8333895 - Attachment is obsolete: true
Attachment #8334328 - Flags: review?(jlal)
Attachment #8334328 - Attachment mime type: text/plain → text/html
Comment on attachment 8334328 [details]
Pull request

Concept looks good but we need integration tests that hit device storage (executeScript)
Attachment #8334328 - Flags: review?(jlal) → review-
Hi James,

I added the integration tests.
Please check it out.

Thanks.
Comment on attachment 8334328 [details]
Pull request

Hi James, 

I updated the patch for your comments.
Please help me to review the patch.
Thanks. :)
Attachment #8334328 - Flags: review- → review?(jlal)
Just to clarify our irc conversation- I would also like to add a test which ensures we are saving the correct bytes (and more importantly b2g reads the correct bytes). This can be done via round tripping some small ascii data or whatever random bytes make you happy. I outlined what I thought made sense before.

I can pick up this part if you don't feel comfortable writing it right now but I would love to see this as it is the last piece that is not 100% tested :)
Flags: needinfo?(gaye)
cc punam, since she will work on marionette test of video app.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(jlal)
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: