Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Description • 11 years ago

We should update to django-rest-framework 2.3.8.

We're currently using 2.3.6. We should update to 2.3.8 which has the fix for requiring booleanfields and also some other things that look helpful.

http://django-rest-framework.org/topics/release-notes.html#23x-series

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 1 • 11 years ago

Pushing this off to 2014q1 because I can't get to it this quarter.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 2 • 10 years ago

Moving this to 2014q2.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 3 • 10 years ago

Bumping this to 2014q3 when I plan to do a round of updates of things.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 4 • 10 years ago

One thing to note, in order to upgrade to django-rest-framework >= 2.4, we have to first upgrade South to 1.0.

Ergo, I'm going to have this block on the South upgrade.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 5 • 10 years ago

I moved the south bug to next quarter. Moving this one, too.

	Michael Cooper [:mythmon]
	Comment 6 • 9 years ago

DRF 3.0 is out now. It is a big of a larger change than upgrading to 2.4, but I think it is worth the change.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 7 • 9 years ago

Why do you think it's worth going to 3.0 rather than 2.4?

	Michael Cooper [:mythmon]
	Comment 8 • 9 years ago

The way that custom serializers and fields are made has been simplified, and is a lot easier to reason about in my opinion. Additionally, there is future work in 3.1 and 3.2 that was sponsored by a Kickstarter campaign that looks useful, like explicit support for API versioning.

Maybe it doesn't actually make sense to spend the effort to upgrade to 3.0 (it will take more work than upgrading to 2.4), but I think 3.0 is an improvement over 2.4.

	Ricky Rosario [:rrosario, :r1cky] Assignee
	Comment 9 • 9 years ago

I'm going to start by upgrading to the latest 2.4.x as long as it supports django 1.7 since that's our goal here. Then I can file a followup to upgrade to DRF 3.x.

	Ricky Rosario [:rrosario, :r1cky] Assignee
	Comment 10 • 9 years ago

In a pull request:
https://github.com/mozilla/fjord/pull/463

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 11 • 9 years ago

Landed in master in: https://github.com/mozilla/fjord/commit/6fe9630128336d4c435a96324b1fd2bcb57d693a

I'll deploy it later today. When deploying, we need to make sure that everything continues to look normal in regards to posting feedback.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 12 • 9 years ago

Pushed it out just now. It looks good, but I'll keep an eye on it for a bit.

Going to mark it as FIXED.