Closed
Bug 929889
Opened 11 years ago
Closed 11 years ago
Remove 'portrait-primary' lock in system app.
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alive, Assigned: gasolin)
References
Details
Attachments
(1 file)
46 bytes,
text/x-github-pull-request
|
alive
:
review+
praghunath
:
approval-gaia-v1.2-
|
Details | Review |
System app still has some 'portrait-primary' orientation lock. pps/system/js/attention_screen.js: screen.mozLockOrientation('portrait-primary'); apps/system/js/attention_screen.js: screen.mozLockOrientation('portrait-primary'); apps/system/js/cards_view.js: screen.mozLockOrientation('portrait-primary'); apps/system/js/lockscreen.js: screen.mozLockOrientation('portrait-primary'); apps/system/js/sleep_menu.js: screen.mozLockOrientation('portrait-primary'); Need to change to ScreenLayout.defaultOrientation instead.
Reporter | ||
Comment 3•11 years ago
|
||
Comment on attachment 822173 [details] [review] pull request redirect to github r=me. (pure bug 911053 needs rebase again...)
Attachment #822173 -
Flags: review?(alive) → review+
Assignee | ||
Comment 4•11 years ago
|
||
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/8a0f40c4ea58738da3ad7d07ac5e4facc6bd184b thanks!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 822173 [details] [review] pull request redirect to github NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] part of koi+ fix [Bug caused by] (feature/regressing bug #): bug 908601 [User impact] if declined: not fully support 'default' keyword in certain apps [Testing completed]: [Risk to taking this patch] (and alternatives if risky): [String changes made]:
Attachment #822173 -
Flags: approval-gaia-v1.2?
Comment 6•11 years ago
|
||
Comment on attachment 822173 [details] [review] pull request redirect to github Minus for now. What would the impact be if default is not translated?
Attachment #822173 -
Flags: approval-gaia-v1.2? → approval-gaia-v1.2-
Reporter | ||
Comment 7•11 years ago
|
||
The orientation might be wrong on tablet when user calls sleepmenu, lockscreen, cardview.
You need to log in
before you can comment on or make changes to this bug.
Description
•