Closed Bug 928306 Opened 11 years ago Closed 11 years ago

[Flatfish][System] Make system dialogs not fill full screen

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Other
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

Attachments

(4 files)

Make system dialogs not fill full screen, have modal dialog instead
Blocks: flatfish
Assignee: nobody → gasolin
Attached image alert
Attached image confirm
Attached image prompt
change based on gaia-local modifications https://github.com/gaia-local/gaia/pull/76/files
Attachment #820131 - Flags: review?(alive)
Comment on attachment 820131 [details]
pull request redirect to github

CSS only and Tablet only change r=me
Attachment #820131 - Flags: review?(alive) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 820131 [details]
pull request redirect to github

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment] CSS only and Tablet only change
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: tablet only
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]:
Attachment #820131 - Flags: approval-gaia-v1.2?
Comment on attachment 820131 [details]
pull request redirect to github

Draw back the v1.2 approval since there's still some dialogs need to be updated.
Its better to have them all in a release version, which we could not commit it will happens in v1.2.

It might be better to let vendor decide if they want cherry-pick this to v1.2
Attachment #820131 - Flags: approval-gaia-v1.2?
Blocks: 935816
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: