Closed
Bug 920357
Opened 11 years ago
Closed 11 years ago
[Flatfish][Homescreen] Add the ability to dismiss app grid edit mode by tapping in an area of the view where there is no icon
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(blocking-b2g:-, b2g-v1.2 affected)
People
(Reporter: gduan, Assigned: gduan)
References
Details
Attachments
(1 file)
Add the ability to dismiss app grid edit mode by tapping in an area of the view where there is no icon.
Assignee | ||
Comment 1•11 years ago
|
||
This patch add click event listener when in edit mode and go back to normal mode by clicking non-icon area.
Updated•11 years ago
|
blocking-b2g: --- → koi?
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 809635 [details]
PR to master
Hi Vivien,
Could you help me review this patch?
UX suggest to click non-icon space to cancel edit mode.
Thanks.
Attachment #809635 -
Flags: review?(21)
Comment 3•11 years ago
|
||
Comment on attachment 809635 [details]
PR to master
I'm fine with the code but I want to make sure Christian knows about it.
Attachment #809635 -
Flags: review?(crdlc)
Attachment #809635 -
Flags: review?(21)
Attachment #809635 -
Flags: feedback+
Comment 5•11 years ago
|
||
Comment on attachment 809635 [details]
PR to master
Please address my comment on github and check if while you are in edit mode and move to other page starting the gesture over a place without icon, this new behavior is not performed. I guess that it shouldn't be so but please check that.. Thanks a great work!
Attachment #809635 -
Flags: review?(crdlc) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Thanks, Vivien and Christian. I've addressed your advice and tested, it works as expected. Merged into master, https://github.com/mozilla-b2g/gaia/commit/2dffbc3ccf4a50dd78c0bc624a8ac419d30a0cc1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 7•11 years ago
|
||
It's UX request feature for 1.2. request koi+ for uplift permission
status-b2g-v1.2:
--- → affected
Comment 8•11 years ago
|
||
(In reply to Fred Lin [:gasolin] from comment #7) > It's UX request feature for 1.2. request koi+ for uplift permission It's a feature and we are past the FC deadline. So approval-request with risk-analysis is the way to go :)
blocking-b2g: koi? → -
You need to log in
before you can comment on or make changes to this bug.
Description
•