Peter Pin-Guang Chen [:petercpg] (MozTW.org) Assignee
	Description • 11 years ago

We're removing Google, popping up Yahoo, and adding Netvibes, feedly, Aol Reader, InoReader after discussion in mailing list.

feedly won't be added to Fennec since it will redirect users to another landing page to download their app.

It's expected to land to aurora and central repo.

	Axel Hecht [:Pike]
	Comment 1 • 11 years ago

Did you reach out to those services to get permission for including them in Firefox yet?

	Peter Pin-Guang Chen [:petercpg] (MozTW.org) Assignee
	Comment 2 • 11 years ago

Nope. Are we required to do so?

	Axel Hecht [:Pike]
	Comment 3 • 11 years ago

Comment on attachment 807252 [details] [diff] [review]
9a3d9f7cf26f.patch

Review of attachment 807252 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, please.

Canceling review request until we have feedback.

	Irvin (MozTW)
	Comment 4 • 11 years ago

As my opinion, we should have someone from Mozilla to contact international service providers, rather than have each local communities do the same things. 

Filed bug 927299 for that.

	Francesco Lodolo [:flod]
	Comment 5 • 7 years ago

@Peter
Now that bug 927299 has been clarified, do you want to go ahead with this patch (I haven't checked if it still applies).

Note that AOL Reader should be removed, since it's shutting down
https://reader.aol.com/eos

	Francesco Lodolo [:flod]
	Comment 6 • 6 years ago

Peter, any update here?

	Peter Pin-Guang Chen [:petercpg] (MozTW.org) Assignee
	Comment 7 • 6 years ago

Thanks for pinging. 

Here's a new patch: 
* Adds Netvibes, Feedly, InoReader, The Old Reader
* Removes AOL Reader & Digg Reader
* All subscription URL are in https
* Unifies the name "My Yahoo!"
* Feedly: use new subscription link

	Francesco Lodolo [:flod]
	Comment 8 • 6 years ago

Comment on attachment 8973500 [details] [diff] [review]
23bfd8061226.patch

Review of attachment 8973500 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Peter, it looks good.

For future patches:
* You should split out patches for SeaMonkey (and Thunderbird). I've CCed Ian, hopefully it's OK to land this with just my review.
* You should provide a fully formed patch (including author, commit message, etc.) instead of a diff, e.g.
https://mozilla-l10n.github.io/documentation/tools/mercurial/creating_mercurial_patch.html#creating-a-patch-using-queues

	Francesco Lodolo [:flod]
	Comment 9 • 6 years ago

Landed in https://hg.mozilla.org/l10n-central/zh-TW/rev/880efe02eef2728631d48f88699e49d546b61671

	Irvin (MozTW)
	Comment 10 • 6 years ago

this is landed in central and already work in nightly, does it means that we can expect it will go with train and be available in Firefox 62? (just want to track when will be there)

	Francesco Lodolo [:flod]
	Comment 11 • 6 years ago

(In reply to Irvin (MozTW) from comment #10)
> this is landed in central and already work in nightly, does it means that we
> can expect it will go with train and be available in Firefox 62? (just want
> to track when will be there)

It will be already in 61.

	Irvin (MozTW)
	Comment 12 • 6 years ago

(In reply to Francesco Lodolo [:flod] from comment #11)
> It will be already in 61.

great!