gasolin@mozilla.com Reporter
	Description • 11 years ago

Expect:

Modify and Merge experiment tablet work from 

https://github.com/gaia-local/gaia

to master

	Greg Weng [:snowmantw][:gweng][:λ]
	Comment 7 • 11 years ago

Comment on attachment 791923 [details]
Change_Homescreen.png

Currently change homescreen won't work: press the change button and nothing happens, except it will goes back to the homescreen.

	Greg Weng [:snowmantw][:gweng][:λ]
	Comment 9 • 11 years ago

(In reply to Greg Weng [:snowmantw] from comment #3)
> Created attachment 791925 [details]
> Passcode.png

UPDATE:

Passcode seems fine at the device. See Attachment 792575 [details].

	gasolin@mozilla.com Reporter
	Comment 10 • 11 years ago

pre comment 7, I think its because we dont have another homescreen app. Maybe a bug that should disabled the change button if current is the default homescreen.

	Steven Yang [:styang]
	Comment 11 • 11 years ago

Nice to have at current stage.

	Steven Yang [:styang]
	Comment 12 • 11 years ago

It's a must for flatfish. koi+

	Francis Lee [:frlee]
	Comment 13 • 11 years ago

Flatfish only UI change, move to 1.3+.

	Francis Lee [:frlee]
	Comment 14 • 11 years ago

according to 10/18 meeting result, ETA date will be 11/5 (ready for review), 11/14 landed.

	Tzu-Lin Huang [:dwi2][:tzhuang] Assignee
	Comment 15 • 11 years ago

Update: WIP is at https://github.com/dwi2/gaia/commits/bug903918

	Tzu-Lin Huang [:dwi2][:tzhuang] Assignee
	Comment 17 • 11 years ago

Hi Arthur,
Please kindly help to review this patch, Thanks

	Francis Lee [:frlee]
	Comment 18 • 11 years ago

implementation resource and ETA date are both agree with RD team. this has to be done before 1.3FC

hi arthur,

can you please kindly support this review?

	Arthur Chen [:arthurcc][inactive after 6/30]
	Comment 19 • 11 years ago

As there are changes of multiple tablet apps in common, we will have a meeting discussing this today. Plan to finish the review within this week.

	Arthur Chen [:arthurcc][inactive after 6/30]
	Comment 20 • 11 years ago

Comment on attachment 827810 [details] [review]
pull request

Cancel the review at first per a offline discussion with tzu-lin. He needs some time to rebase to master.

	Tzu-Lin Huang [:dwi2][:tzhuang] Assignee
	Comment 21 • 11 years ago

Comment on attachment 827810 [details] [review]
pull request

Hi Arthur,
I've finish all rebase and clean up work, please help to review the patch.
Thanks

	Arthur Chen [:arthurcc][inactive after 6/30]
	Comment 22 • 11 years ago

Comment on attachment 827810 [details] [review]
pull request

Thank you for the patch. r=me with the followup bug (removing the dup code with building block) created and green travis.

	Tzu-Lin Huang [:dwi2][:tzhuang] Assignee
	Comment 23 • 11 years ago

The followup bug is bug 943173

	Tzu-Lin Huang [:dwi2][:tzhuang] Assignee
	Comment 24 • 11 years ago

master
https://github.com/mozilla-b2g/gaia/commit/2d1f0e90f9918ce6059eed878f7ea5e68a9879b3