Closed Bug 881939 Opened 11 years ago Closed 11 years ago

Enable source maps by default

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 24

People

(Reporter: fitzgen, Assigned: fitzgen)

References

(Blocks 1 open bug)

Details

(Keywords: doc-bug-filed)

Attachments

(1 file)

v1
1.15 KB, patch
past
: review+
Details | Diff | Splinter Review 
Right now the pref to use source maps is false by default. If a user has source maps, they almost always want to use them. Only the tool authors usually want to turn it off, or if there is a bug in the tool generating the source map. At least 95% of the time, they want them to be enabled.
Attached patch v1 — — Splinter Review 
Will this regress the performance hacks you just landed, Panos?
Assignee: nobody → nfitzgerald
Attachment #761187 - Flags: review?(past)
Comment on attachment 761187 [details] [diff] [review]
v1

Review of attachment 761187 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Nick Fitzgerald [:fitzgen] from comment #1)
> Will this regress the performance hacks you just landed, Panos?

Nope, I took care of that in the final version of that patch.
Attachment #761187 - Flags: review?(past) → review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/ac87c834bb7c
Status: NEW → ASSIGNED
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/ac87c834bb7c
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
Depends on: 885272
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: